627675 - "add version" button not working after an extension has been submitted

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Armando Stellato]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.642.2 Safari/534.16
Build Identifier: 

See last comment on this other bug, since it is quite related to this:
https://bugzilla.mozilla.org/show_bug.cgi?id=314664#c42
the relationship is that the button is not working when submitting our add-on, not that it is not working in general (we tried with success to upload other extensions)
Our add-on is quite big (7mb) and has some java jars inside.

Reproducible: Always

Steps to Reproduce:
1. download xpi from http://semanticturkey.googlecode.com/files/SemanticTurkey-0.7.2-2011-01-20_b130.1.xpi
2. try to upload it as a new extension

Actual Results:  
the check to the extension will be done. It will report mostly (more than 5K) warnings due to the presence of class files inside the jars (.class is a discouraged extension, though we know it is allowed to write extensions with firefox-java interaction...however, this is not the issue).
Then, the button, when clicked, does not activate anything...

Expected Results:  
to get the new version added :-)

Comment 1

[Armando Stellato]

The "numb" button happens when I tried to upload a new version for my already existing extension. I now tried to upload it as if it were a new extension. The button is active now, but then I get to this error page:

Oops! We had an error.
We'll get to fixing that soon.
You can try refreshing the page, or head back to the Add-ons homepage.

Comment 2

[Wil Clouser [:clouserw]]

Attachment: screenshot

I can't reproduce this (screenshot is off of addons.allizom.org, not production).

Are you sure you don't have old cached JS?  Can you do a hard refresh of the page?

Comment 3

[Armando Stellato]

Hi Wil,

I'm able to get to the point represented by your screenshot, and the button looks blue (so active), but I'm not able to click on it (reproduced by some colleagues on different machines).
Tested again (refreshed, hard refreshed etc...), from https://addons.mozilla.org/developers/addon/semantic-turkey/versions/ I get the above error (as explained in comment 1)
from: https://addons.allizom.org/developers/addon/semantic-turkey/versions/add
instead, after clicking on the button, I get the following error:
File not found
not able to locate file https://addons.allizom.org/it/developers/addon/semantic-turkey/versions/add.

Comment 4

[Wil Clouser [:clouserw]]

We had some queue troubles for a bit, I'm not sure if that was related. QA: can you reproduce this?  I can't.

Comment 5

[krupa raj[:krupa]]

I get a traceback  while uploading the test file as a new add-on

traceback details:

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 109, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 77, in wrapper
   return f(*args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 69, in wrapper
   return f(*args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 24, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 814, in wrapper
   return f(request, *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 847, in submit_addon
   if form.is_valid():

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/forms/forms.py", line 121, in is_valid
   return self.is_bound and not bool(self.errors)

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/forms/forms.py", line 112, in _get_errors
   self.full_clean()

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/forms/forms.py", line 267, in full_clean
   self._clean_fields()

 File "/data/amo_python/www/preview/zamboni/vendor/src/happyforms/happyforms/__init__.py", line 27, in _clean_fields
   value = field.clean(value.strip())

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/forms/fields.py", line 169, in clean
   value = self.to_python(value)

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/forms/models.py", line 1007, in to_python
   value = self.queryset.get(**{key: value})

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/query.py", line 337, in get
   num = len(clone)

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/query.py", line 82, in __len__
   self._result_cache = list(self.iterator())

 File "/data/amo_python/www/preview/zamboni/vendor/src/django-cache-machine/caching/base.py", line 106, in __iter__
   obj = iterator.next()

 File "/data/amo_python/www/preview/zamboni/vendor/src/django-cache-machine/caching/base.py", line 181, in fetch_by_id
   cache.set_many(new)

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/cache/backends/memcached.py", line 98, in set_many
   self._cache.set_multi(safe_data, self._get_memcache_timeout(timeout))

 File "/data/amo_python/www/preview/zamboni/vendor/lib/python/memcache.py", line 643, in set_multi
   write("set %s %d %d %d\r\n%s\r\n" % (key, store_info[0], time, store_info[1], store_info[2]))

TypeError: 'int' object is unsubscriptable

Comment 6

[Wil Clouser [:clouserw]]

Attachment: screenshot2

I just uploaded it as a new add-on on allizom and it also worked fine (see screenshot).  The validator has been changing a lot over the past couple weeks.  I'm going to close this since I can't reproduce it - please try again with your add-on.

Comment 7

[Armando Stellato]

Hi Wil,

sorry for asking again, but I tried again from two different locations, and got same result as above, while your screenshot leaves my previous question unreplied. Are you sure you went past the window you reported in your screenshot? I'm also able to get to the window reporting the extension has passed all tests, but I cannot go any further.
I made now a couple of test:
1) on mozilla, by uploading a new version of Semantic Turkey. Same problem as before, the button becomes blue but when I click to continue it does nothing
2) on allizom, by uploading Semantic Turkey as a totally new extension. I was able to click the button, but then it returned me an error page:

"Oops! Si è verificato un errore.
Cercheremo di risolvere il problema al più presto.
Puoi provare a ricaricare la pagina o ritornare alla pagina iniziale."

Comment 8

[Armando Stellato]

Attachment: where I get stuck...

This attachment shows the same window you manage to reach (though in italian). Unfortunately, either I'm not able to click on the blue button "aggiungi una versione" or I get then an error page "Oops! Si è verificato un errore.
Cercheremo di risolvere il problema al più presto.
Puoi provare a ricaricare la pagina o ritornare alla pagina iniziale."

Comment 9

[Wil Clouser [:clouserw]]

(In reply to comment #8)
> Created attachment 509966 [details]
> where I get stuck...
> 
> This attachment shows the same window you manage to reach (though in italian).
> Unfortunately, either I'm not able to click on the blue button "aggiungi una
> versione" or I get then an error page "Oops! Si è verificato un errore.
> Cercheremo di risolvere il problema al più presto.
> Puoi provare a ricaricare la pagina o ritornare alla pagina iniziale."

Your "Oops!...." message is the same thing krupa got in comment 5, and it looks like it's in the cache machine.  What do you think of this, jbalogh?

Comment 10

[Jeff Balogh (:jbalogh)]

1. It is peculiar that cache-machine is getting invoked since devhub is supposed to bypass it altogether.
2. I have no idea why memcache.py would crash.

Comment 12

[Jeff Balogh (:jbalogh)]

I think the memcache error occurs because we're sending an object larger than 1MB. The validator generates 2966254 bytes of output, which is 2.8MB.

Until I can figure out how to work around this, reducing warnings in the affected packages will let them be added.

(Your add-on passed validation with 0 errors and 5191 warnings.)

Comment 13

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/4d42808 

Krupa: If this works on preview I'd like to ship it today.

Comment 14

[krupa raj[:krupa]]

I was able to upload the test file without any failures (https://addons.allizom.org/en-US/developers/addon/cold-turkey/submit/7)

I am not marking this bug VERIFIED since this is a temporary solution.

Comment 15

[krupa raj[:krupa]]

 
> I am not marking this bug VERIFIED since this is a temporary solution.

Looks like I was mistaken about this being a temporary fix.

Comment 16

[Boris Ruf]

In my case, the problem is fixed now - thanks!

Comment 17

[Armando Stellato]

yep!!! it works it works! sorry but it's the end of a more-than-year wait, and I'm happy like a kid seeing our extension back online! :-) 
Thanks a lot to all of you for the great work and dedication!

Comment 18

[Armando Stellato]

Gosh...

...again and again...and again....and again...

the nightmare is back...

Try to download this:

http://semanticturkey.googlecode.com/files/SemanticTurkey-0.8.0-2011-10-11_b145.1.xpi

and now upload it. Again, xpi fully uploaded, then...nothing, the progress bar continues to flash with upload to 100%, and nothing happens. The button to go ahead is clickable (the mouse pointer changes shape) but it does not bring anywhere...

1) pls solve it :-)
2) is it possible to get the xpi uploaded in the meanwhile? last time we had to wait one entire year to get the bug fixed, and we couldn't upload the xpi in any other way...

Thx in advance

Comment 19

[krupa raj[:krupa]]

(In reply to Armando Stellato from comment #18)
> Gosh...

> 
> http://semanticturkey.googlecode.com/files/SemanticTurkey-0.8.0-2011-10-
> 11_b145.1.xpi
> 

I was able to upload this file onto addons-dev without any errors. Can you use Firebug and check if there are any errors listed in the JSON requests?

Comment 20

[Armando Stellato]

Hi krupa,

on https://addons-dev.allizom.org/ it (partially) works, in the sense that after the upload, we're able to click the button to publish it. Unfortunately, it tells 0.8.0 is already up (consider we're not uploading a new ext but a new version of an existing one). Anyway, this seems to be another issue (maybe it is related to a first uncomplete upload we did, though it is still not normal since the most up-to-date version is not 0.8.0 but 0.7.2r due to that uncomplete upload).

Differenty, it is on the "true" developer hub site that we get stuck (it is exactly the same behavior we experienced in the past, so just take previous messages from months ago and same screenshots as a reference). And, just wondering, maybe it's some past code which became reapplied to the current version.

Btw, here follow the erros we got from firebug.

Thx a lot for your help!

A is null
truncate()devhub...cd1563f (riga 1) 
D = Object { type="upload_success_results", timeStamp=1318364475295, jQuery1318364343816=true, altri elementi...}
y = Object { name="SemanticTurkey-0.8.0.xpi", size=7249739, type="application/x-xpinstall"}
A = null
a()common...cd1563f (riga 16) 
a0 = Object { type="upload_success_results", timeStamp=1318364475295, jQuery1318364343816=true, altri elementi...}
a()common...cd1563f (riga 16)
a()common...cd1563f (riga 16) 
a0 = Object { type="upload_success_results", timeStamp=1318364475295, jQuery1318364343816=true, altri elementi...}
a4 = [Object { type="upload_success_results", timeStamp=1318364475295, jQuery1318364343816=true, altri elementi...}, Object { name="SemanticTurkey-0.8.0.xpi", size=7249739, type="application/x-xpinstall"}, null]
a2 = input#upload-addon
a()common...cd1563f (riga 16)
a()common...cd1563f (riga 16) 
a3 = [input#upload-addon]
a7 = function()
a2 = undefined
a()common...cd1563f (riga 16) 
a1 = function()
a0 = undefined
a()common...cd1563f (riga 16) 
a0 = "upload_success_results"
a1 = [Object { name="SemanticTurkey-0.8.0.xpi", size=7249739, type="application/x-xpinstall"}, null]
truncate()devhub...cd1563f (riga 1) 
I = null
a2()common...cd1563f (riga 23)
a2()common...cd1563f (riga 23) 
bm = readystatechange 
$.fn.truncate=function(b){b=b||{};if(z...ger-download").trigger("download")}}); 
devhub...cd1563f (riga 1)

Comment 21

[Armando Stellato]

sorry, replace: "it is on the true developer hub site" which is maybe misleading,
I meant just:
https://addons.mozilla.org/

Comment 22

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/