No resizer when status bar is turned off

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Bug 489303 has made it possible to turn on scrollbars on the web page when the status bar is turned off.
(Assignee)

Comment 1

6 years ago
Created attachment 505822 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #505822 - Flags: review?(philip.chee)

Comment 2

6 years ago
Comment on attachment 505822 [details] [diff] [review]
Proposed patch

> +  getBrowser().showWindowResizer = !window.fullScreen &&
> +      !isElementVisible(document.getElementById("status-bar"));

I can never remember the indentation rules for this sort of situation. Is four spaces correct here?

While testing this patch I ran into Bug 626997. Perhaps you need to port attachment 505499 [details] [diff] [review] as well.
Attachment #505822 - Flags: review?(philip.chee)
(Assignee)

Comment 3

6 years ago
Created attachment 506214 [details] [diff] [review]
With maximise fix

There is an edge case where the resize listener doesn't work but somehow I doubt that users will manually resize their browser to the particular size.
Attachment #505822 - Attachment is obsolete: true
Attachment #506214 - Flags: review?(philip.chee)

Comment 4

6 years ago
Comment on attachment 506214 [details] [diff] [review]
With maximise fix

r=me

>    addEventListener("PopupCountChanged", UpdateStatusBarPopupIcon, true);
>  
>    addEventListener("AppCommand", HandleAppCommandEvent, true);
>  
> +  addEventListener("resize", updateWindowResizer, false);

Optionally remove the blank lines in between these addEventListener(s) on checkin.
Attachment #506214 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 5

6 years ago
Pushed changeset 0c665572476a to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.