Closed Bug 627974 Opened 9 years ago Closed 6 years ago

Arrow panel hidden behind Windows taskbar when browser not maximized

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30
Tracking Status
firefox29 --- fixed
firefox30 --- fixed

People

(Reporter: george.carstoiu, Assigned: Gijs)

References

Details

(Whiteboard: [4b10][good first verify])

Attachments

(5 files)

Attached image Screenshot 1
Build identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre

When browser is not maximized, the arrow panel is displayed in the background of the windows taskbar. Use attached "testcase" to test.

Steps to reproduce:
 1. Minimize browser such as the lower part of the window comes close to the windows taskbar, but it's not in contact with it.
 2. Open attached "testcase" and scroll page until you reach the bottom of the page
 3. Press "Submit"

Actual results:
 - the arrow panel is hidden behind the windows taskbar (Screenshot 1)
 
Expected results:
 - the arrow panel is displayed in such way that it is fully visible
Attached file Testcase
Algorithm that calculates space on the screen where the panel could be displayed should take into account the taskbar
Component: General → XUL Widgets
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
The popup uses level="parent", so that (from bug 561636) "if a form gets autosubmitted while the browser is behind another app's window, the popup [isn't] shown on top of the other app."

This causes the popup to appear above the firefox window but behind other windows.

So it seems the suggestion in comment 2 is a better option here. On Windows and GTK, popups can overlap the taskbar and other OS chrome. We could change this perhaps only for those popups with level='parent'.
Whiteboard: [4b10]
OS: Windows 7 → All
Hardware: x86 → All
It would be indeed better to make sure these panels can overlay the taskbar instead of making them appear on top of all windows.
I've made this change only for panels, not for other types of popups, but those checks could be removed if that were better...
Attachment #8372383 - Flags: review?(enndeakin)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Blocks: 963078
Comment on attachment 8372383 [details] [diff] [review]
panels that aren't toplevel shouldn't overlap the taskbar,

>     if (screen) {
>+      // Non-top-level panels should never overlap the OS bar:
>+      bool dontOverlapOSBar = mPopupType == ePopupTypePanel &&
>+                              aPopupLevel != ePopupLevelTop;

Non-panels are always ePopupLevelTop so the type check is redundant.
Attachment #8372383 - Flags: review?(enndeakin) → review+
Comment on attachment 8372383 [details] [diff] [review]
panels that aren't toplevel shouldn't overlap the taskbar,

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/95fc024ee46d
Attachment #8372383 - Flags: checkin+
(In reply to :Gijs Kruitbosch from comment #7)
> Comment on attachment 8372383 [details] [diff] [review]
> panels that aren't toplevel shouldn't overlap the taskbar,
> 
> remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/95fc024ee46d

Meant to comment: removed the redundant check, and clarified the comments I added that mentioned panels based on comment #6.
https://hg.mozilla.org/mozilla-central/rev/95fc024ee46d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Comment on attachment 8372383 [details] [diff] [review]
panels that aren't toplevel shouldn't overlap the taskbar,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: Australis' main menu panel goes underneath the Windows task bar when a subview is opened. This is bug 963078 (relatively new because we only recently switched to a non-top-level panel) which already has 5 dupes at time of writing. This is clearly affecting people a lot.
Testing completed (on m-c, etc.): On m-c, locally
Risk to taking this patch (and alternatives if risky): Low, alternative workarounds in bug 963078 aren't attractive and probably higher risk.
String or IDL/UUID changes made by this patch: none
Attachment #8372383 - Flags: approval-mozilla-aurora?
Egh, forgot I needed a branch patch.
Attachment #8372383 - Flags: approval-mozilla-aurora?
Comment on attachment 8372811 [details] [diff] [review]
panels that aren't toplevel shouldn't overlap the taskbar,

Carrying over review, requesting approval on the patch that landed on m-c instead.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: Australis' main menu panel goes underneath the Windows task bar when a subview is opened. This is bug 963078 (relatively new because we only recently switched to a non-top-level panel) which already has 5 dupes at time of writing. This is clearly affecting people a lot.
Testing completed (on m-c, etc.): On m-c, locally
Risk to taking this patch (and alternatives if risky): Low, alternative workarounds in bug 963078 aren't attractive and probably higher risk.
String or IDL/UUID changes made by this patch: none
Attachment #8372811 - Flags: review+
Attachment #8372811 - Flags: approval-mozilla-aurora?
Attachment #8372811 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Duplicate of this bug: 968658
Whiteboard: [4b10] → [4b10][good first verify]
Duplicate of this bug: 672365
Depends on: 1401477
You need to log in before you can comment on or make changes to this bug.