Closed Bug 628051 Opened 10 years ago Closed 10 years ago

Remove killNewTabGroup

Categories

(Firefox Graveyard :: Panorama, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 4.0b11

People

(Reporter: mitcho, Assigned: mitcho)

References

Details

(Whiteboard: [cleanup][ux][qa-])

Attachments

(2 obsolete files)

killNewTabGroup was originally part of the "implementing new tab experience" bug 575851, but now it is completely inappropriate to ship this. In particular, it will automagically close any group that someone created called "New Tabs" after a reboot. Scary!
Attached patch Trivial patch (obsolete) — Splinter Review
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Attachment #506148 - Flags: review?(ian)
Whiteboard: [cleanup][ux] → [cleanup][ux][qa-]
Comment on attachment 506148 [details] [diff] [review]
Trivial patch

Yes!
Attachment #506148 - Flags: review?(ian) → review+
Attachment #506148 - Flags: approval2.0?
Comment on attachment 506148 [details] [diff] [review]
Trivial patch

a=beltzner, virtuous
Attachment #506148 - Flags: approval2.0? → approval2.0+
Attached patch Patrch for checkin (obsolete) — Splinter Review
Attachment #506148 - Attachment is obsolete: true
Comment on attachment 506823 [details] [diff] [review]
Patrch for checkin

Wrong patch :)
Attachment #506823 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/c8ea68010263
Keywords: checkin-needed
Target Milestone: --- → Firefox 4.0b11
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to comment #5)
> Comment on attachment 506823 [details] [diff] [review]
> Patrch for checkin
> 
> Wrong patch :)

Oh no! Thanks for taking care of this!
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.