Closed Bug 628105 Opened 15 years ago Closed 10 years ago

crash in js::gc::MarkString

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME
Tracking Status
blocking2.0 --- .x+

People

(Reporter: cbook, Unassigned)

References

Details

(Keywords: crash, Whiteboard: [softblocker])

Crash Data

Firefox 4.0b10pre Crash Report [@ js::gc::MarkString ] http://crash-stats.mozilla.com/report/list?range_value=2&range_unit=weeks&date=2011-01-23%2000%3A00%3A00&signature=js%3A%3Agc%3A%3AMarkString&version=Firefox%3A4.0b10pre Crashing Thread Frame Module Signature [Expand] Source 0 mozjs.dll js::gc::MarkString js/src/jsgcinlines.h:240 1 mozjs.dll fun_trace js/src/jsfun.cpp:1956 2 mozjs.dll js_TraceObject js/src/jsobj.cpp:6426
maybe connected to bugs tracked under bug 613650?
Blocks: 613650
Looks like fun->atom can be NULL, so we shouldn't mark it in that case. case FUN_NAME: vp->setString(fun->atom ? ATOM_TO_STRING(fun->atom) : cx->runtime->emptyString); break;
Assignee: general → anygregor
blocking2.0: --- → final+
Whiteboard: [softblocker]
Of course fun->atom may be null, but fun_trace already null-checks fun->atom: static void fun_trace(JSTracer *trc, JSObject *obj) { /* A newborn function object may have a not yet initialized private slot. */ JSFunction *fun = (JSFunction *) obj->getPrivate(); . . . if (fun->atom) MarkString(trc, ATOM_TO_STRING(fun->atom), "atom"); /be
If its not something trivial, we don't have STR, so we can't block on this for now, except if we get a ton of volume.
blocking2.0: final+ → ?
Its relatively low volume but it looks like this was running 10-20 crashes per day before the release of beta9. now its running 40-55 crashes per day. currently ranked #94 on b9. we should probably just keep an eye on this one. here is a better query to watch across all releases. http://crash-stats.mozilla.com/report/list?signature=js%3A%3Agc%3A%3AMarkString
blocking2.0: ? → .x
This is #193 on 5.0 Branch and #95 on 4.0 Branch currently.
Summary: Firefox 4.0b10pre Crash Report [@ js::gc::MarkString ] → Firefox 4.0/5.0 Crash Report [@ js::gc::MarkString ]
Crash Signature: [@ js::gc::MarkString ]
i just run into this today - https://crash-stats.mozilla.com/report/index/bp-492f990e-fd14-475a-adc5-9b2dd2120222 only thing i did was getting my mbp out of the sleep mode with pushing the mouse and firefox was crashing
Blocks: 762693
Assignee: anygregor → general
Crash Signature: [@ js::gc::MarkString ] → [@ js::gc::MarkString ] [@ js::gc::MarkString(JSTracer*, js::EncapsulatedPtr<JSAtom, unsigned long>*, char const*)]
OS: Windows 7 → All
Hardware: x86 → All
Summary: Firefox 4.0/5.0 Crash Report [@ js::gc::MarkString ] → crash in js::gc::MarkString
Also encountered twice in a day, both correlated to waking a Mac out of sleep, and scrolling a web page.
Assignee: general → nobody
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.