628252 - os2.cc fails to compile against GCC 4.6, missing #include <cstddef>

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

os2.cc fails to compile on linux, #include <stddef.h> is missing so offsetof() macro is undefined

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: simple patch

Comment 2

[Karl Tomlinson (:karlt)]

Hmm.  Seems to be compiling fine here with glibc-2.11.2 and gcc-4.4.4.  I wonder what is different.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

We just got a gcc 4.6 snapshot in rawhide, which is where this comes from.  (FWIW, unless stransky has another patch for earlier errors, we also need to build with -fpermissive to even get this far.)

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

FWIW, this should really be including <cstddef> since this is C++ code.

http://gcc.gnu.org/ml/gcc-patches/2010-06/msg00257.html
http://gcc.gnu.org/viewcvs?view=revision&revision=160231

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: #include <cstddef>

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Jonathan, this needs to go upstream. How are we tracking our local patches against OTS?

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 508131 [details] [diff] [review]
#include <cstddef>

This is also needed on the 1.9.2 branch...

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/4861b373c563

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 508131 [details] [diff] [review]
#include <cstddef>

Approved for 1.9.2.15, a=dveditz for release-drivers

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 508131 [details] [diff] [review]
#include <cstddef>

Didn't make the code-freeze for non-blockers, you can try again next time.