Closed Bug 628252 Opened 9 years ago Closed 9 years ago

os2.cc fails to compile against GCC 4.6, missing #include <cstddef>

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b12

People

(Reporter: stransky, Assigned: caillon)

References

Details

Attachments

(1 file, 1 obsolete file)

os2.cc fails to compile on linux, #include <stddef.h> is missing so offsetof() macro is undefined
Version: unspecified → Trunk
Attached patch simple patch (obsolete) — Splinter Review
Hmm.  Seems to be compiling fine here with glibc-2.11.2 and gcc-4.4.4.  I wonder what is different.
We just got a gcc 4.6 snapshot in rawhide, which is where this comes from.  (FWIW, unless stransky has another patch for earlier errors, we also need to build with -fpermissive to even get this far.)
FWIW, this should really be including <cstddef> since this is C++ code.

http://gcc.gnu.org/ml/gcc-patches/2010-06/msg00257.html
http://gcc.gnu.org/viewcvs?view=revision&revision=160231
Summary: os2.cc fails to compile on linux, missing <stddef.h> → os2.cc fails to compile against GCC 4.6, missing #include <cstddef>
Attachment #506361 - Attachment is obsolete: true
Attachment #508131 - Flags: review?(roc)
Jonathan, this needs to go upstream. How are we tracking our local patches against OTS?
Comment on attachment 508131 [details] [diff] [review]
#include <cstddef>

This is also needed on the 1.9.2 branch...
Attachment #508131 - Flags: approval1.9.2.15?
Assignee: nobody → caillon
http://hg.mozilla.org/mozilla-central/rev/4861b373c563
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Comment on attachment 508131 [details] [diff] [review]
#include <cstddef>

Approved for 1.9.2.15, a=dveditz for release-drivers
Attachment #508131 - Flags: approval1.9.2.15? → approval1.9.2.15+
Blocks: 643460
Comment on attachment 508131 [details] [diff] [review]
#include <cstddef>

Didn't make the code-freeze for non-blockers, you can try again next time.
Attachment #508131 - Flags: approval1.9.2.17+ → approval1.9.2.17-
You need to log in before you can comment on or make changes to this bug.