Closed
Bug 628258
Opened 14 years ago
Closed 14 years ago
inverted method arguments in treeView.js::_buildVisibleSection
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 4.0b11
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
852 bytes,
patch
|
dietrich
:
review+
dietrich
:
approval2.0+
|
Details | Diff | Splinter Review |
Neil noted this in bug 520659 comment 66:
> > _buildVisibleSection:
> >- function PTV__buildVisibleSection(aContainer, aVisible, aToOpen, aVisibleStartIndex)
> >+ function PTV__buildVisibleSection(aContainer, aFirstChildRow, aToOpen)
> > {
> ...
> >- this._buildVisibleSection(curChild, aVisible, aToOpen, aVisibleStartIndex);
> >+ rowsAddedCounter += this._buildVisibleSection(curChild, aToOpen,
> >+ row + 1);
> Oops... should have been (curChild, row + 1, aToOpen);
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Comment 2•14 years ago
|
||
risk is just that making this properly can discover other bugs we never noticed, but that's the same risk as any other "safe" patch. More likely this will fix some edge-case regression.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #506467 -
Flags: review?(dietrich)
Attachment #506467 -
Flags: approval2.0?
Comment 3•14 years ago
|
||
Comment on attachment 506467 [details] [diff] [review]
patch v1.0 (checked-in)
r+a=me. keep a wary eye out in case any of those edge cases are actually covered by tests.
Attachment #506467 -
Flags: review?(dietrich)
Attachment #506467 -
Flags: review+
Attachment #506467 -
Flags: approval2.0?
Attachment #506467 -
Flags: approval2.0+
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 506467 [details] [diff] [review]
patch v1.0 (checked-in)
http://hg.mozilla.org/mozilla-central/rev/b2a6ee5242f9
Attachment #506467 -
Attachment description: patch v1.0 → patch v1.0 (checked-in)
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Target Milestone: --- → Firefox 4.0b11
Updated•14 years ago
|
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•