Closed Bug 628258 Opened 9 years ago Closed 9 years ago

inverted method arguments in treeView.js::_buildVisibleSection

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b11

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

Neil noted this in bug 520659 comment 66:

> >   _buildVisibleSection:
> >-  function PTV__buildVisibleSection(aContainer, aVisible, aToOpen, aVisibleStartIndex)
> >+  function PTV__buildVisibleSection(aContainer, aFirstChildRow, aToOpen)
> >   {
> ...
> >-          this._buildVisibleSection(curChild, aVisible, aToOpen, aVisibleStartIndex);
> >+          rowsAddedCounter += this._buildVisibleSection(curChild, aToOpen,
> >+                                                        row + 1);
> Oops... should have been (curChild, row + 1, aToOpen);
risk is just that making this properly can discover other bugs we never noticed, but that's the same risk as any other "safe" patch. More likely this will fix some edge-case regression.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #506467 - Flags: review?(dietrich)
Attachment #506467 - Flags: approval2.0?
Comment on attachment 506467 [details] [diff] [review]
patch v1.0 (checked-in)

r+a=me. keep a wary eye out in case any of those edge cases are actually covered by tests.
Attachment #506467 - Flags: review?(dietrich)
Attachment #506467 - Flags: review+
Attachment #506467 - Flags: approval2.0?
Attachment #506467 - Flags: approval2.0+
Comment on attachment 506467 [details] [diff] [review]
patch v1.0 (checked-in)

http://hg.mozilla.org/mozilla-central/rev/b2a6ee5242f9
Attachment #506467 - Attachment description: patch v1.0 → patch v1.0 (checked-in)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b11
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.