Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Port |Bug 628258 - inverted method arguments in treeView.js::_buildVisibleSection| to SeaMonkey

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Bookmarks & History
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.1b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 507473 [details] [diff] [review]
patch [Checkin: comment 1]

Neil noted this in bug 520659 comment 66:

> >   _buildVisibleSection:
> >-  function PTV__buildVisibleSection(aContainer, aVisible, aToOpen, aVisibleStartIndex)
> >+  function PTV__buildVisibleSection(aContainer, aFirstChildRow, aToOpen)
> >   {
> ...
> >-          this._buildVisibleSection(curChild, aVisible, aToOpen, aVisibleStartIndex);
> >+          rowsAddedCounter += this._buildVisibleSection(curChild, aToOpen,
> >+                                                        row + 1);
> Oops... should have been (curChild, row + 1, aToOpen);
Attachment #507473 - Flags: review?(neil)

Updated

7 years ago
Attachment #507473 - Flags: review?(neil) → review+
(Assignee)

Comment 1

7 years ago
Comment on attachment 507473 [details] [diff] [review]
patch [Checkin: comment 1]

http://hg.mozilla.org/comm-central/rev/ed3eef84357c
Attachment #507473 - Attachment description: patch → patch [Checkin: comment 1]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
No longer blocks: 467530
You need to log in before you can comment on or make changes to this bug.