Last Comment Bug 629383 - Port |Bug 628258 - inverted method arguments in treeView.js::_buildVisibleSection| to SeaMonkey
: Port |Bug 628258 - inverted method arguments in treeView.js::_buildVisibleSec...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Bookmarks & History (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: seamonkey2.1b2
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
:
Mentors:
Depends on: 628258
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-27 08:16 PST by Jens Hatlak (:InvisibleSmiley)
Modified: 2011-01-27 09:32 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch [Checkin: comment 1] (2.16 KB, patch)
2011-01-27 08:16 PST, Jens Hatlak (:InvisibleSmiley)
neil: review+
Details | Diff | Splinter Review

Description Jens Hatlak (:InvisibleSmiley) 2011-01-27 08:16:50 PST
Created attachment 507473 [details] [diff] [review]
patch [Checkin: comment 1]

Neil noted this in bug 520659 comment 66:

> >   _buildVisibleSection:
> >-  function PTV__buildVisibleSection(aContainer, aVisible, aToOpen, aVisibleStartIndex)
> >+  function PTV__buildVisibleSection(aContainer, aFirstChildRow, aToOpen)
> >   {
> ...
> >-          this._buildVisibleSection(curChild, aVisible, aToOpen, aVisibleStartIndex);
> >+          rowsAddedCounter += this._buildVisibleSection(curChild, aToOpen,
> >+                                                        row + 1);
> Oops... should have been (curChild, row + 1, aToOpen);
Comment 1 Jens Hatlak (:InvisibleSmiley) 2011-01-27 08:53:12 PST
Comment on attachment 507473 [details] [diff] [review]
patch [Checkin: comment 1]

http://hg.mozilla.org/comm-central/rev/ed3eef84357c

Note You need to log in before you can comment on or make changes to this bug.