628378 - Please drop [] around the expressions in .size assembler directives

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

In mpi_amd64_gas.s there is code like

.size s_mpv_mul_set_vec64, [.-s_mpv_mul_set_vec64]

Using [] is undocumented (at least I couldn't find anything in the gas manual), not as supported and IMHO less clear than ().

Currently this is all that prevents this from being assembled by llvm's integrated assembler. I can fix llvm.org/PR8685 instead, but it looked better to change 4 chars in this file :-)

Comment 1

[Wan-Teh Chang]

Comment on attachment 506509 [details] [diff] [review]
patch

Thanks for the patch.  Let's just remove the [].
The () are not necessary:
http://sourceware.org/binutils/docs/as/Size.html#Size

Comment 2

[Wan-Teh Chang]

Please also fix mozilla/security/nss/lib/freebl/mpi/mpi_amd64_sun.s.
Thanks.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Drop the []

Comment 4

[Wan-Teh Chang]

Comment on attachment 508150 [details] [diff] [review]
Drop the []

r=wtc.

Patch checked in on the NSS trunk (NSS 3.13) and the
NSS_3_12_BRANCH (NSS 3.12.10).

Checking in mpi_amd64_gas.s;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/mpi_amd64_gas.s,v  <--  mpi_amd64_g
as.s
new revision: 1.3; previous revision: 1.2
done
Checking in mpi_amd64_sun.s;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/mpi_amd64_sun.s,v  <--  mpi_amd64_s
un.s
new revision: 1.2; previous revision: 1.1
done

Checking in mpi_amd64_gas.s;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/mpi_amd64_gas.s,v  <--  mpi_amd64_g
as.s
new revision: 1.2.70.1; previous revision: 1.2
done
Checking in mpi_amd64_sun.s;
/cvsroot/mozilla/security/nss/lib/freebl/mpi/mpi_amd64_sun.s,v  <--  mpi_amd64_s
un.s
new revision: 1.1.198.1; previous revision: 1.1
done

Comment 6

[(no longer active)]

How can we get this patch on to mozilla-central?  Should we wait for the next NSS update?  Or can we land it on our own?

Comment 7

[Wan-Teh Chang]

ehsan: please wait for the next NSS update.

Comment 8

[(no longer active)]

Wan-Teh: do you know when the next NSS update is going to be?  We need these patches on mozilla-central really soon.  Is this OK that we just go ahead and land this bug and bug 629839 on mozilla-central if the NSS update is not going to happen until next week?