628384 - Bypass graphics blacklist on reftest and mochitest

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: force-enable gfx features in reftests

This is a cousing of bug 628377, refer to it for context.

This patch bypasses the graphics blacklist in reftests.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Note: blocking hardblocker bug 623338 too.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 506511 [details] [diff] [review]
force-enable gfx features in reftests

Please don't do it this way; see bug 608030, which I'll hopefully land in an hour or two.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In particular, runreftest.py should be a helpful script, and not required; prefs that are important for correct testing should be set in the harness, as the patch there does.)

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: force-enable gfx features in reftests, updated

Like this?

(can't be sure as there were multiple patches in the bug you mentioned)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 506870 [details] [diff] [review]
force-enable gfx features in reftests, updated

This is ok, but it applies it to both reftest and mochitest and some other test suites.

If you only need reftest, it might be better to do only reftest, which would mean patching the pref-setting code in http://hg.mozilla.org/mozilla-central/file/6a097e294828/layout/tools/reftest/reftest-cmdline.js#l95

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 506870 [details] [diff] [review]
force-enable gfx features in reftests, updated

marking review- to prompt response to previous comment, in case you missed it

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Thanks, I had actually missed it :-)

I need this to apply to all tests that run on test slaves, so the fact that it applies to mochitests, if unintentional, is very welcome. So far there is only one mochitest that should be affected, the WebGL mochitest, and I was addressing this directly in it.

Given that it's a good thing that this applies to all tests, i set this back to r?.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 506870 [details] [diff] [review]
force-enable gfx features in reftests, updated

r=dbaron

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

Since drivers were upgraded today on test slaves, this is no longer needed.

Thanks for your help and sorry for the noise! I couldn't know how long it would
take to update the drivers on test slaves.

I guess that INVALID is the most appropriate bug resolution...

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

Reopening! Indeed, only the Win7 test slaves have up-to-date drivers, the WinXP slaves don't. So I really need to land this patch.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 506870 [details] [diff] [review]
force-enable gfx features in reftests, updated

a2.0=dbaron

Comment 12

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/5bea893dd9b2

Comment 13

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: only apply to win32

oops! should only have applied that to win32.

Comment 14

[(no longer active)]

Comment on attachment 507988 [details] [diff] [review]
only apply to win32

r- because this also affects locally run tests.

This sounds to me like something that we'd want to fix on the test slaves, not on the machines of every developer working on the project.