bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Remove nsVoidArray from /Ldap/Xpcom

ASSIGNED
Assigned to

Status

Directory
LDAP XPCOM SDK
ASSIGNED
8 years ago
4 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
{
/ldap/xpcom/src/nsLDAPURL.h
    * line 43 -- #include "nsVoidArray.h"

/ldap/xpcom/src/nsLDAPService.cpp
    * line 169 -- // implemented as a "stack" on top of the nsVoidArrays, since we can
}
(Assignee)

Comment 1

6 years ago
Created attachment 646184 [details] [diff] [review]
(Av1) nsLDAPServiceEntry, PopListener() and PushListener(): Fix documentation, Improve code

Only 1 left:
{
/ldap/xpcom/src/nsLDAPService.cpp
    * line 130 -- // implemented as a "stack" on top of the nsVoidArrays, since we can
}

At first glance, this code was initially added in bug 70422, then modified in bug 177400.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/directory/xpcom/base/src/nsLDAPService.cpp&rev=1.29#153
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/directory/xpcom/base/src/nsLDAPService.h&rev=1.11#104

***

(Untested :-|)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #646184 - Flags: review?(mbanner)
(Assignee)

Updated

6 years ago
Depends on: 70422
Attachment #646184 - Flags: review?(mbanner) → review+
(Assignee)

Comment 2

4 years ago
Comment on attachment 646184 [details] [diff] [review]
(Av1) nsLDAPServiceEntry, PopListener() and PushListener(): Fix documentation, Improve code

Ftr, this patch was bitrotted by
http://hg.mozilla.org/comm-central/rev/fd2f5a37ef5f
Bug 859817 - Followup: Fix implicit conversions to already_AddRefed in nsLDAPService.cpp.

Yet, I think a few bits could still (be) apply...
You need to log in before you can comment on or make changes to this bug.