Closed
Bug 62880
Opened 24 years ago
Closed 23 years ago
javascript prompt() does not select default text
Categories
(Core :: XUL, defect, P4)
Tracking
()
Future
People
(Reporter: tpowellmoz, Assigned: bzbarsky)
References
()
Details
(Keywords: polish)
Attachments
(1 file)
591 bytes,
patch
|
Details | Diff | Splinter Review |
Using Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20001213. The JavaScript window.prompt() function generates a dialog to get information from the user. If default text is included in the call, it would be nice for the text to be automatically selected when the dialog appears so that the user can immediately type over it. This is very useful in bookmarklets, such as the bugzilla bookmarklet. The text is automatically selected in Netscape 4.x and IE 5, so Mozilla feels less friendly here.
Reporter | ||
Updated•24 years ago
|
Comment 1•24 years ago
|
||
->danm p4/moz101
Assignee: trudelle → danm
Priority: P3 → P4
Target Milestone: --- → mozilla1.0.1
Comment 2•24 years ago
|
||
Can't find a duplicate of this (doesn't mean one doesn't exist). Marking NEW
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•23 years ago
|
||
Assignee | ||
Comment 4•23 years ago
|
||
Taking bug. This patch will actually make all sorts of dialogs that only have one textfield default to selecting that textfield. ccing mpt for his thoughts, and requesting review.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0.1 → mozilla0.9.3
Assignee | ||
Updated•23 years ago
|
Keywords: mozilla0.9.3
Comment 5•23 years ago
|
||
Seems reasonable to me, but whadda I know. Maybe you should ping alecf, blake or ben for [s]r.
Assignee | ||
Comment 6•23 years ago
|
||
ccing blake and alec. What do you think of this change?
Comment 7•23 years ago
|
||
It shouldn't apply just to those dialogs which have only one text field. *** This bug has been marked as a duplicate of 28583 ***
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 8•23 years ago
|
||
Er. Right. Except we're _not_ tabbing to the dialog; we're focusing it programmatically. Under those circumstances, will the fix to bug 28583 apply? I would say that this one-line fix is worth getting in even if bug 28583 is not fixed....
Assignee | ||
Comment 9•23 years ago
|
||
mpt, does tabbing into a widget _always_ select its contents? On all platforms? The behavior asked for in this bug should be platform-independent, it seems to me.....
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 10•23 years ago
|
||
pushing out pending response from mpt...
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Comment 11•23 years ago
|
||
> Except we're _not_ tabbing to the dialog; we're focusing it programmatically. See the 2000-12-26 23:40 comment in bug 28583. > mpt, does tabbing into a widget _always_ select its contents? On all > platforms? See the 2001-04-16 12:11 comment in bug 28583.
Assignee | ||
Comment 12•23 years ago
|
||
> See the 2000-12-26 23:40 comment in bug 28583. Thank you. > See the 2001-04-16 12:11 comment in bug 28583. This implies that the code in bug 28583 will not select the text on Linux... In my view, the text described in this bug should be selected on all platforms. If I'm wrong about either of those, please feel free to re-dup the bug.
Comment 13•23 years ago
|
||
In fact, default text has a very severe length limit, and will not diplay any text with a newline character, except for the last line.
Reporter | ||
Comment 14•23 years ago
|
||
*** Bug 96407 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.4 → Future
Comment 16•23 years ago
|
||
> This implies that the code in bug 28583 will not select the text on Linux...
> In my view, the text described in this bug should be selected on all
> platforms.
Why? Surely that would hork the selection clipboard on X just like any other
selection would. I still think this is a dup.
Assignee | ||
Comment 17•23 years ago
|
||
Keyboard selections don't hork the clipboard... just mouse ones do. So there should be a mechanism for selection without keyboard horkage. That said, I think I've come to agree that this is a dup (and don't have the time to deal with pushing this through even if it were not. :) ) *** This bug has been marked as a duplicate of 28583 ***
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 18•23 years ago
|
||
So does this mean the attached patch is just getting thrown away? I'd much rather have some dialogs automatically do the default text selection than none, <rant>especially if it means waiting another year until some progress is made</rant>. Can't this minimal patch be checked in (assuming it still works) until bug 28583 is fixed? Thanks for the work on this, Boris. I think I know what you mean about not having the time to push this through. Should bug 49574 be added to the block list for 28583? Or perhaps treated as a dup? It seems identical to this bug.
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•