62885 - Message/Mark All Read doesn't get disabled when there are no (zero) unread messages/all messages are read

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID : 2000121408.

Message/Mark All Read doesn't get ghosted after a successful marking.

Steps to Repro:

1. Go to any newsgroup
2. Go to Message/Mark All Read

Expected Results:

This function should Mark All Messages As Read and then become ghosted out like
As Read/Thread As Read already are.

Actual Results:

Function is not ghosted out.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Saw this also on my Windows 2000 box, 2000121404.

Comment 2

[(not reading, please use [e-mail] instead)]

ghosted == disabled.  updating topic, accepting.

Comment 3

[laurel]

Hmmm, don't know all the rules, here, but 4.x doesn't disable it.
In the case of As Read/Thread Read, those are message selection related items as
opposed to All Read being overall group/folder related so applicable rules might
differ.  In your example, I don't know if you had anything selected in the
thread/message panes or whether you were operating solely on overall
group/folder selection.
If you select a message which has no unread components, As Read and Thread Read
are still enabled (4.x or 6.x), too.  So I'm not sure of your point.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

It's not news specific.  You can go to a folder that has only read messages, no
new ones. Put focus in the message/thread window and make sure you've got only
read messages selected.  You'll see that some menu items are still available,
like Mark All Read.  This would be a fine option, if you had even a single
unread message, which I don't. 

Comment 5

[Arun Prasannan (polar)]

This bug is being marked EXPIRED as it has seen no activity in a very long time.

If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you.

http://www.seamonkey-project.org/

Comment 6

[Mark Banner (:standard8)]

Bulk reopening incorrectly expired bugs - no activity does not constitute no bug - these need proper checking.

Comment 7

[Philip Chee]

Problem still exists.

Comment 8

[Shriram (irc: Mavericks)]

Is someone working on a patch for this?

Comment 9

[Kent James (:rkent)]

Probably (In reply to comment #8)
> Is someone working on a patch for this?

Probably not, since it is unassigned.

Comment 10

[Shriram (irc: Mavericks)]

So, referring to comment #4

Comment 11

[Shriram (irc: Mavericks)]

ignore my last comment.
referring to comment #3, I think if the "Mark all read " feature is to be ghosted out, then it would make sense to disable the "Mark read" feature for the one read message or X read messages out of all messages.
So, do users request this feature to be enabled?
This issue also exists in the latest version of seamonkey(2.01bpre)

Comment 12

[Jan Horak [:jhorak]]

Attachment: Patch to disable "Mark all" when all mail in folder has been read

Comment 13

[Jan Horak [:jhorak]]

Attachment: Path 0.2

I'm sorry I forgot to remove bogus diffs from patch file.

Comment 14

[Phil Ringnalda (:philor)]

Comment on attachment 384879 [details] [diff] [review]
Path 0.2

Sorry, for no reason I can explain, I just can't wrap my head around whether or not this is the right thing to do, so I'm going to punt.

Comment 15

[David :Bienvenu]

Comment on attachment 384879 [details] [diff] [review]
Path 0.2

doesn't mark all read work on multiple folders now?

Comment 16

[David :Bienvenu]

If this is for marking the messages in the thread pane read, I would go through the view's folder to see if there are any unread, not the folder pane selection...

Comment 17

[David :Bienvenu]

Comment on attachment 384879 [details] [diff] [review]
Path 0.2

this seems wrong to me per my previous comment.

Comment 18

[Edmund Wong (:ewong)]

If [e-mail] does not object, I'd like to take this bug for a spin.

Comment 19

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #18)
> If [e-mail] does not object, I'd like to take this bug for a spin.

This bug is not assigned to anyone -> free to take.

Comment 20

[Edmund Wong (:ewong)]

Taking this bug for a spin.

Comment 21

[Edmund Wong (:ewong)]

Attachment: Disable Message->Mark All Read when there are no (zero) unread messages.

Comment 22

[Philip Chee]

You should follow the style in rest of the code in DefaultController.

+             var dbView = GetDBView();
+             var numRead = dbView.msgFolder.getNumUnread(false);
+             if (numRead <= 0) {
+               return false;
+             }
+             return true;

All the above can be replaced by:

return (gDBView && gDBView.msgFolder.getNumUnread(true) > 0) // Use true See Comment 16.

Also you've fixed the wrong line (supportsCommand:). You should fix it in the isCommandEnabled: section.

Comment 23

[Edmund Wong (:ewong)]

Attachment: Disable Message->Mark All Read when there are no (zero) unread messages. (v2)

Comment 24

[Philip Chee]

> +        return (gDBView && (gDBView.msgFolder.getNumUnread(false) <= 0));
I think you want the condition to be > 0

Comment 25

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #24)
> > +        return (gDBView && (gDBView.msgFolder.getNumUnread(false) <= 0));
> I think you want the condition to be > 0

I'd just wait for Karsten's review. For example the parentheses are unnecessary, too (except for the function call ones of course), but that's just a matter of style (i.e. I think there's no point in uploading new patches unless you have a crystal ball or something similar telling you what the reviewer wants).

Comment 26

[Karsten Düsterloh]

Comment on attachment 515291 [details] [diff] [review]
Disable Message->Mark All Read when there are no (zero) unread messages. (v2)

>Bug 62885 - Disable Message->Mark All Read when there are no (zero) unread messages.
                              =============
>       case "cmd_markAsRead":

This is the wrong command, you need to fix cmd_markAllRead. 

>+        return (gDBView && (gDBView.msgFolder.getNumUnread(false) <= 0));

This should be >0 and you need none of the braces.
Besides, you could just mimic e.g. cmd_markThreadAsRead and check GetNumSelectedMessages().
But don't forget the old condition...

>       case "cmd_markThreadAsRead":
>         return GetNumSelectedMessages() > 0;
>       case "button_next":

It'd be a good idea if you make your hg do 8 lines of context, i.e. this into your global .hgrc:
[diff]
git=true
showfunc=true
unified=8

[defaults]
diff=-U 8
qdiff=-U 8

Comment 27

[Karsten Düsterloh]

(In reply to comment #26)
> check GetNumSelectedMessages().

Oops, that nonsense, of course. getNumUnread is the right function.

Comment 28

[Edmund Wong (:ewong)]

Attachment: Disable Message->Mark All Read when there are no (zero) unread messages. [Checkin: comment 30]

Comment 29

[Karsten Düsterloh]

Comment on attachment 518336 [details] [diff] [review]
Disable Message->Mark All Read when there are no (zero) unread messages. [Checkin: comment 30]

r/moa=me.

Comment 30

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 518336 [details] [diff] [review]
Disable Message->Mark All Read when there are no (zero) unread messages. [Checkin: comment 30]

http://hg.mozilla.org/comm-central/rev/3b55dfd8506e

Comment 31

[Jim Porter (:squib)]

Should this be fixed for Thunderbird as well?

Comment 32

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #31)
> Should this be fixed for Thunderbird as well?

That sounds like a question you should ask a TB reviewer, in a TB bug. ;-)