650702 - Message/Mark All Read doesn't get disabled when there are no (zero) unread messages/all messages are read

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jim Porter (:squib)]

+++ This bug was initially created as a clone of Bug #62885 +++

Build ID : 2000121408.

Message/Mark All Read doesn't get ghosted after a successful marking.

Steps to Repro:

1. Go to any newsgroup
2. Go to Message/Mark All Read

Expected Results:

This function should Mark All Messages As Read and then become ghosted out like
As Read/Thread As Read already are.

Actual Results:

Function is not ghosted out.

Comment 1

[Jim Porter (:squib)]

Question to clarkbw/bwinton: should we also disable "mark all read" in message tabs/windows (no matter what their folders look like)?

It seems like that shouldn't be allowed, since there's no easy way for the user to see the state of the folder. I'd be a little peeved if I accidentally marked the wrong folder read because of that. This would probably imply that we should just get rid of the "mark all read" item entirely in the standalone message window, since there's no way it could ever be enabled.

Comment 2

[Jim Porter (:squib)]

Attachment: Fix this and add tests

This is just a copy of the Seamonkey change, plus tests. It doesn't change things for message tabs/windows, since that's probably a separate bug.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 529336 [details] [diff] [review]
Fix this and add tests

Review of attachment 529336 [details] [diff] [review]:

I see "Mark Thread As Read" as always being enabled (on the Mac), so we might want to fix that, too, around line 407.

But really, other than the minor nit below, I like this patch.

(If you want to do the thread change in this, then re-request review from me please.  If you want to do that in a separate patch, then feel free to mark this one as checkin-needed.)

Thanks,
Blake.

::: mail/base/content/mail3PaneWindowCommands.js
@@ -431,3 +431,4 @@
       case "cmd_undoCloseTab":
         return (document.getElementById("tabmail").recentlyClosedTabs.length > 0);               
       case "cmd_markAllRead":
+        return IsFolderSelected() && gDBView && gDBView.msgFolder.getNumUnread(false) > 0;

I think we can split this up to be less than 80 characters

Comment 4

[Jim Porter (:squib)]

Check in with nit fixed: http://hg.mozilla.org/comm-central/rev/05f568581019

I filed bug 654362 for the mark thread as read case.