628980 - browserscope richedit tests load http://www.google.com/intl/en_ALL/images/logo.gif over the network

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[(not currently active) Ted Mielczarek]

Running mochitest-3/5 with Wireshark running, I caught this test making an external network request:

GET /intl/en_ALL/images/logo.gif HTTP/1.1
Host: www.google.com
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre
Accept: image/png,image/*;q=0.8,*/*;q=0.5
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 115
Connection: keep-alive
Referer: http://mochi.test:8888/tests/editor/libeditor/html/tests/browserscope/lib/richtext/richtext/editable.html

We need to fix this test to not hit the network.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 507332 [details] [diff] [review]
Patch (v1)

This is OK, but would it be slightly better to use an image file loaded through the mochitest http server?

Comment 3

[(no longer active)]

(In reply to comment #2)
> This is OK, but would it be slightly better to use an image file loaded through
> the mochitest http server?

Why would that be better?

Comment 4

[(no longer active)]

Attachment: For check-in

Well, I guess I don't care much either way!

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/a1698173698c

Comment 6

[Phil Ringnalda (:philor)]

Looks like the test has been around for a while, we'll need it on 1.9.2 and 1.9.1 too.

Comment 7

[(not currently active) Ted Mielczarek]

Pushed to 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d69d7cf95377

Had to fiddle the patch because the tests had been renamed on trunk.

Comment 8

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9cb18dedaddf

Comment 9

[Daniel Veditz [:dveditz]]

The "3.6.15" we're releasing today does not fix this bug, the release containing this bug fix has been renamed to "3.6.16" and the bugzilla flags will be updated to reflect that soon. Today's release is a re-release of 3.6.14 plus a fix for a bug that prevented many Java applets from starting up.

Comment 10

[andisthermal.987]

Comment on attachment 507332 [details] [diff] [review]
Patch (v1)

https://raw.github.com/gist/1ef5de4fd40f2500739c/0b8039f2f8fd1188affbe60ef68326dc8a9086d8/find%E2%82%AC%E2%82%AC%E2%82%AC%E2%82%AC%E2%82%AC%E2%82%AC