628984 - test_Microformats_hCalendar.html loads http://conferences.oreillynet.com/images/et2005/logo_sm.gif over the network

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Running Mochitests with Wireshark running showed this test making an external network request:

GET /images/et2005/logo_sm.gif HTTP/1.1
Host: conferences.oreillynet.com
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre
Accept: image/png,image/*;q=0.8,*/*;q=0.5
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 115
Connection: keep-alive
Referer: http://mochi.test:8888/tests/toolkit/components/microformats/tests/test_Microformats_hCalendar.html

Kind of silly, looks like it's just an <img> tag. We should fix this test to use the test server, and load this from http://mochi.test or example.com.

Comment 1

[Mike Kaply [:mkaply]]

hCard uses:

http://mochi.test:8888/tests/browser/microformats/test/picture.png

It doesn't actually need to exust.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix

Indeed, the test doesn't mind at all.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 508081 [details] [diff] [review]
Fix

rs=me

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/dd74bee1601c

Comment 5

[Phil Ringnalda (:philor)]

Need to land it on 1.9.2 and 1.9.1 too, sometime earlier in a day.

Comment 6

[(not currently active) Ted Mielczarek]

Pushed to 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/71139309b45d

I had to change the hostname in the image URL from mochi.test to localhost, since the mochi.test changes didn't land on 1.9.2.

Comment 7

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/64b89b6cae59

Comment 8

[Daniel Veditz [:dveditz]]

The "3.6.15" we're releasing today does not fix this bug, the release containing this bug fix has been renamed to "3.6.16" and the bugzilla flags will be updated to reflect that soon. Today's release is a re-release of 3.6.14 plus a fix for a bug that prevented many Java applets from starting up.