629095 - Same add-on is listed twice under /featured

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons.allizom.org/en-US/firefox/admin/features
2. choose locale = unspecified, application = Firefox
3. Add "Yahoo! Mail notifier" as a featured add-on
4. Change the locale to en-US and repeat step #3
5. Check the add-ons listed under https://addons.allizom.org/en-US/firefox/featured

expected behavior:
Each featured add-on is listed only once.

actual behavior:
Yahoo! Mail notifier is listed twice. See https://addons.allizom.org/en-US/firefox/featured

Comment 1

[Jeff Balogh (:jbalogh)]

select distinct is bad news.

Comment 2

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/ea88b2cf403fdfc3de3f317776baf917f18a6ed4

Comment 3

[krupa raj[:krupa]]

Checked that-
* An add-on is listed only once
* adding locale-specific featured add-ons works
* adding locale-specific creatured add-ons work
* locale-specific featured add-ons are listed only for that locale
* locale-specific creatured add-ons are listed only for that locale
* locale-specific add-ons are listed before unspecified add-ons
* We rotate the creatured add-ons randomly
* If there are 3 creatured add-ons for a locale, we list the 3 add-ons for that category in a random order.