62916 - [RFE]install needs to be able to refresh plugins

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, enhancement, P1)

Description

[Daniel Veditz [:dveditz]]

Must be able to do the equivalent of "navigator.plugins.refresh(true)" from an
install script after having installed a plugin.

Comment 1

[Daniel Veditz [:dveditz]]

We need the refresh feature to work before we can support this in the install 
script.

Comment 2

[Robert Williams]

   navigator.plugins.refresh(true);
elicites the following in install.log:
     ** Line: 53        navigator is not defined

     Install **FAILED** with error -229

Comment 3

[Daniel Veditz [:dveditz]]

We are not planning on supporting the "navigator" object in the install script 
(see bug 7022 for discussion). We will be implementing an "equivalent of" that, 
details to be determined but probably something straightforward like 
Install.refreshPlugins().

Comment 4

[av (gone)]

navigator.plugins.refresh is now supported in the plugin code. Reassigning to 
the owner of the selected component.

Comment 5

[av (gone)]

Oops, sorry, I should have probably not reassigned it. Rolling back.

Comment 6

[Daniel Veditz [:dveditz]]

Attachment: patches for new feature

Comment 7

[Daniel Veditz [:dveditz]]

A few new files are included in the patch. Not included are the required 
changes to the Mac projects -- I promise I will not forget those when checking 
in.

Comment 8

[Sean Su]

r=ssu

Comment 9

[Scott MacGregor]

ok, sr=mscott

I'm going home now. If you need more super reviews tonight, aim me at home.

Comment 10

[Daniel Veditz [:dveditz]]

fix checked-in 3/13/2001

Comment 11

[Jimmy Lee]

Build: 2001-03-20-09-Mtrunk(WIN), 2001-03-20-08-trunk(MAC), 
2001-03-20-13-Mtrunk(LINUX)

This is working on all platforms.

http://jimbob/jars/a_refreshplugins_win.xpi
http://jimbob/jars/a_refreshplugins_mac.xpi
http://jimbob/jars/a_refreshplugins_linux.xpi

Marking Verified!

Comment 12

[Arun Ranganathan]

Unfortunately, this doesn't work.  Try installing any plugin and then calling
navigator.plugins.refresh(1) from the XPInstall script.  The plugin and the
corresponding mime types array are NOT refreshed.  Re-opening.  Note that since
this was on the 0.8.1 radar, and dveditz checked in a fix, this is clearly a
regression.  

Comment 13

[Arun Ranganathan]

nominating mozilla0.9.2 since this appears to be a real serious regression that
blocks EA.
Re-assigning to syd in dveditz's absence.

Comment 14

[Sean Su]

This is actually fixed as Dan and Jimmy had indicated.  The function to call to 
refresh the plugins from within the xpinstall context is:
  refreshPlugins();

it'll return an error value as well (0 if successfull).  I'll attach a sample 
.js script.

Comment 15

[Sean Su]

Attachment: sample .js script used by a .xpi file

Comment 16

[Jimmy Lee]

No code changes made.  This still works as verified from 3/20/2001.  Marking 
Verified.

Comment 17

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.