629514 - Use public domain headers for our tests

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Ian Gilman [:iangilman]]

Instead of the boiler plate we're using at the top of all of our tests, we should just use:

/* Any copyright is dedicated to the Public Domain.
   http://creativecommons.org/publicdomain/zero/1.0/ */

Obviously this is not a big deal, but we might as well fix our old tests at some point, and certainly all of our new tests should have this.

Thanks to sdwilsh for pointing this out!

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Is it appropriate to keep the Contributor(s) information in the header, below the "public domain" notice? The information can be useful when debugging some test issues, and can be faster than going to the hg log.

Comment 2

[Shawn Wilsher :sdwilsh]

You could keep it in a second block, but really, are we talking about optimizing mere seconds of lookup time for the (hopefully) rare case of fixing a broken test?

Comment 3

[Shawn Wilsher :sdwilsh]

(in general, the contributors section in most files isn't useful because people do not frequently add themselves to it)

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Okay then... simple public domain notice, then. Thanks Shawn.

Comment 5

[Raymond Lee [:raymondlee]]

Attachment: v1

Trivial patch, just update headers and no actual code changes.

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 514713 [details] [diff] [review]
v1

Yup, looks good. The only question I have is a technical one: do we need any sort of permission from the original developers to change the licenses? Obviously files written under contract for Mozilla do not have this issue, but I suspect we have a few in here which were not, but still copied the license header which says "The Initial Developer ... is Mozilla". :/

Comment 7

[Raymond Lee [:raymondlee]]

(In reply to comment #6)
> Comment on attachment 514713 [details] [diff] [review]
> v1
> 
> Yup, looks good. The only question I have is a technical one: do we need any
> sort of permission from the original developers to change the licenses?
> Obviously files written under contract for Mozilla do not have this issue, but
> I suspect we have a few in here which were not, but still copied the license
> header which says "The Initial Developer ... is Mozilla". :/

Who is the best person we can ask about this?

Comment 8

[Shawn Wilsher :sdwilsh]

(In reply to comment #6)
> Yup, looks good. The only question I have is a technical one: do we need any
> sort of permission from the original developers to change the licenses?
> Obviously files written under contract for Mozilla do not have this issue, but
> I suspect we have a few in here which were not, but still copied the license
> header which says "The Initial Developer ... is Mozilla". :/
Yes you do.

Comment 9

[Raymond Lee [:raymondlee]]

(In reply to comment #8)
> (In reply to comment #6)
> > Yup, looks good. The only question I have is a technical one: do we need any
> > sort of permission from the original developers to change the licenses?
> > Obviously files written under contract for Mozilla do not have this issue, but
> > I suspect we have a few in here which were not, but still copied the license
> > header which says "The Initial Developer ... is Mozilla". :/
> Yes you do.

Checked the patch. Most of the tests were written by the Panorama team (Ian, Mitcho, Sean, Tim and me).  There are two tests by Ehsan and one by Patrick Walton.  

@Ehsan and Patrick: is it ok to change the license in the test files you created?

Comment 10

[Patrick Walton (:pcwalton)]

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #6)
> > > Yup, looks good. The only question I have is a technical one: do we need any
> > > sort of permission from the original developers to change the licenses?
> > > Obviously files written under contract for Mozilla do not have this issue, but
> > > I suspect we have a few in here which were not, but still copied the license
> > > header which says "The Initial Developer ... is Mozilla". :/
> > Yes you do.
> 
> Checked the patch. Most of the tests were written by the Panorama team (Ian,
> Mitcho, Sean, Tim and me).  There are two tests by Ehsan and one by Patrick
> Walton.  
> 
> @Ehsan and Patrick: is it ok to change the license in the test files you
> created?

Yup.

Comment 11

[Shawn Wilsher :sdwilsh]

(In reply to comment #9)
> @Ehsan and Patrick: is it ok to change the license in the test files you
> created?
ehsan is employed by mozilla, so the copyright is to the foundation anyway ;)

Comment 12

[(no longer active)]

(In reply to comment #11)
> (In reply to comment #9)
> > @Ehsan and Patrick: is it ok to change the license in the test files you
> > created?
> ehsan is employed by mozilla, so the copyright is to the foundation anyway ;)

What sdwilsh said, and furthermore, it would be fine if I were the copyright owner myself!  :-)

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

I'm fine with the license changes, too!

Comment 14

[Raymond Lee [:raymondlee]]

Comment on attachment 514713 [details] [diff] [review]
v1

Trivial change.  Only update the licenses so this patch doesn't have any risks.

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 514713 [details] [diff] [review]
v1

test changes don't need approval

Comment 16

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Trivial change. Only updated licenses in test files.

Comment 17

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/621e26f42542