Closed
Bug 629538
Opened 12 years ago
Closed 12 years ago
Upgrade ANGLE to r550
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: vlad, Assigned: bjacob)
References
Details
(Whiteboard: [hardblocker])
Attachments
(3 files)
1.49 MB,
patch
|
Details | Diff | Splinter Review | |
25.28 KB,
patch
|
Details | Diff | Splinter Review | |
139.98 KB,
patch
|
Details | Diff | Splinter Review |
To pick up a bunch of perf and security fixes.
Updated•12 years ago
|
blocking2.0: --- → final+
Whiteboard: [hardblocker]
Assignee | ||
Comment 1•12 years ago
|
||
This imports ANGLE r550 by overwriting existing files, which also has the effect of unapplying our local patches.
Attachment #508140 -
Flags: review?(vladimir)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #508141 -
Flags: review?(vladimir)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #508142 -
Flags: review?
Assignee | ||
Updated•12 years ago
|
Attachment #508142 -
Flags: review? → review?(vladimir)
Reporter | ||
Comment 4•12 years ago
|
||
r=me on all of this, too afraid to open a 1.5MB patch file
Assignee | ||
Updated•12 years ago
|
Summary: Upgrade ANGLE to r540 (at least 540) → Upgrade ANGLE to r550
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/268957af2047 http://hg.mozilla.org/mozilla-central/rev/af518fbee564 http://hg.mozilla.org/mozilla-central/rev/e0cc3c15ef08
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 6•12 years ago
|
||
Comment on attachment 508141 [details] [diff] [review] update and apply angle patches >-@@ -73,21 +93,21 @@ typedef enum { >- SH_OBJECT_CODE = 0x0004, >- SH_ATTRIBUTES_UNIFORMS = 0x0008 >- } ShCompileOptions; >- >- // >- // Driver must call this first, once, before doing any other >- // compiler operations. >- // >--int ShInitialize(); >-+ANGLE_API int ShInitialize(); >- // >- // Driver should call this at shutdown. >- // >--int ShFinalize(); >-+ANGLE_API int ShFinalize(); >- >- // >- // Implementation dependent built-in resources (constants and extensions). >- // The names for these resources has been obtained by stripping gl_/GL_. >- // >- typedef struct >- { >- // Constants. Why was this removed? non-libxul builds still need it.
Comment 7•12 years ago
|
||
(In reply to comment #6) > Why was this removed? non-libxul builds still need it. Ah, I see bug 629971 covers that.
Assignee | ||
Updated•12 years ago
|
Attachment #508140 -
Flags: review?(vladimir)
Assignee | ||
Updated•12 years ago
|
Attachment #508141 -
Flags: review?(vladimir)
Assignee | ||
Updated•12 years ago
|
Attachment #508142 -
Flags: review?(vladimir)
You need to log in
before you can comment on or make changes to this bug.
Description
•