Closed Bug 629889 Opened 9 years ago Closed 9 years ago
open all in tabs is broken from Library when no browser window is open
The changes in bug 562998 completely broke PlacesUIUtils._openTabset when no browser window is open. Steps: 1. open browser window. 2. open Library 3. close the browser window 4. try to open tabs, "open all in tabs" or group of tabs. In PlacesUIUtils._openTabset: > var where = aWindow.whereToOpenLink(aEvent, false, true); whereToOpenLink function was not design to return "window" when there is no browser window!!! also there is typo - aWindow.openDialog(win.getBrowserURL(), "_blank", - "chrome,all,dialog=no", urls.join("|")); + aWindow.openDialog(aWindow.getBrowserURL(), "_blank", + "chrome,all,dialog=no", urls.join("|"));
we should probably either fix this regression or backout the fix before the final, asking softblocking.
blocking2.0: --- → ?
9 years ago
Status: NEW → ASSIGNED
Comment on attachment 508473 [details] [diff] [review] readability thanks.
Attachment #508473 - Flags: review?(mak77) → review+
Comment on attachment 508473 [details] [diff] [review] readability Asking approval or blocking to land this regression fix. low risk since mostly restoring old code behavior.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
> Steps: > 1. open browser window. > 2. open Library > 3. close the browser window > 4. try to open tabs, "open all in tabs" or group of tabs. Problem seems to be fixed. Unable to reproduce with Mozilla/5.0 (Windows NT 5.1; rv:2.0b11) Gecko/20100101 Firefox/4.0b11 ID:20110202143949
Verified on Linux, too: Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre
Status: RESOLVED → VERIFIED
Whiteboard: [softblocker] → [softblocker][bugday0204]
Whiteboard: [softblocker][bugday0204] → [softblocker][bugday0204][fx4-fixed-bugday]
Whiteboard: [softblocker][bugday0204][fx4-fixed-bugday] → [softblocker][fx4-fixed-bugday]
Target Milestone: --- → Firefox 4.0b11
8 years ago
You need to log in before you can comment on or make changes to this bug.