Closed Bug 629990 Opened 13 years ago Closed 4 years ago

mochitest-plain-3: "file_testcommon.js" finishes tests too early

Categories

(Core :: Networking: Cookies, defect, P5)

defect

Tracking

()

RESOLVED INVALID

People

(Reporter: sgautherie, Unassigned)

References

()

Details

(Whiteboard: [necko-would-take])

(Noticed (on SeaMonkey) while checking bug 628589.)

{
9670 INFO TEST-END | /tests/extensions/cookie/test/test_differentdomain.html | finished in 6615ms
9671 INFO TEST-START | /tests/extensions/cookie/test/test_image.html
Document http://example.com/tests/extensions/cookie/test/file_domain_inner.html loaded successfully

9739 INFO TEST-END | /tests/extensions/cookie/test/test_same_base_domain.html | finished in 5373ms
9740 INFO TEST-START | /tests/extensions/cookie/test/test_same_base_domain_2.html
Document http://test1.example.org/tests/extensions/cookie/test/file_domain_inner.html loaded successfully

9769 INFO TEST-END | /tests/extensions/cookie/test/test_samedomain.html | finished in 6012ms
9770 INFO TEST-START | /tests/gfx/test_acceleration.html
Document http://example.org/tests/extensions/cookie/test/file_domain_inner.html loaded successfully
}

file_domain_inner.html load should be logged before its TEST-END, not after TEST-START of the next test!

http://mxr.mozilla.org/mozilla-central/search?string=file_domain_inner.html&case=1&find=%2Fextensions%2Fcookie%2Ftest%2F
Maybe other tests relying on file_testcommon.js are affected too?

Hopefully, it just misses a SimpleTest.executeSoon()...

***

Also, to be safe, SimpleTest.waitForExplicitFinish() should be called _before_ setupTest() is called.
Whiteboard: [necko-would-take]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P5

These tests work fine. Closing this bug as invalid.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.