[SeaMonkey] mochitest-plain-4: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows 2003 too)

VERIFIED FIXED in Firefox 11

Status

()

defect
P2
major
VERIFIED FIXED
9 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Depends on 1 bug, Blocks 1 bug)

Trunk
mozilla12
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox10 wontfix, firefox11 verified, firefox-esr10 affected)

Details

(Whiteboard: [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 11b5: Fv2] [perma-orange][qa-], )

Attachments

(5 attachments, 4 obsolete attachments)

2.49 KB, patch
joe
: review+
Details | Diff | Splinter Review
2.77 KB, patch
joe
: review+
Details | Diff | Splinter Review
4.53 KB, patch
masayuki
: review+
Details | Diff | Splinter Review
8.02 KB, patch
jrmuizel
: review-
Details | Diff | Splinter Review
2.65 KB, patch
joe
: review+
Details | Diff | Splinter Review
Maybe acceleration is not (yet) enabled/supported on SeaMonkey builders?
Assignee

Comment 1

9 years ago
Windows is affected too:
"9576 ERROR TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on Windows"
Summary: [SeaMonkey] mochitest-plain-3: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X" → [SeaMonkey] mochitest-plain-3: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows too)
Comment hidden (Legacy TBPL/Treeherder Robot)
dropping [SeaMonkey] per ehsan's c#2
Summary: [SeaMonkey] mochitest-plain-3: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows too) → mochitest-plain-3: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows too)
Assignee

Comment 4

9 years ago
(In reply to comment #2)
> http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295989472.1295991548.30030.gz
> Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test mochitests-3/5 on
> 2011/01/25 13:04:32

A Firefox "random" is ("interesting" but) not this bug.
(Unless the underlying issue could be explained.)


(In reply to comment #3)
> dropping [SeaMonkey] per ehsan's c#2

Well, no.
Summary: mochitest-plain-3: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows too) → [SeaMonkey] mochitest-plain-3: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows too)
(In reply to comment #4)
> (In reply to comment #3)
> > dropping [SeaMonkey] per ehsan's c#2
> 
> Well, no.

Are we sure its not the same bug; if so, why? if not I think we should defer to this being a Firefox intermittent atm.
Assignee

Comment 6

9 years ago
(In reply to comment #5)
> Are we sure its not the same bug; if so, why? if not I think we should defer to
> this being a Firefox intermittent atm.

100% sure? No. It might be the same bug, but there is no evidence of that atm.
Thus I don't think 1 Firefox random should "hide" days of SeaMonkey perma-failures on two platforms just yet.

What I'd like to know is whether acceleration is actually supported/enabled on these SeaMonkey builders (when running the browser manually for example)...
Assignee

Comment 7

9 years ago
[Mozilla/5.0 (Windows NT 5.0; rv:2.0b11pre) Gecko/20110126 Firefox/4.0b11pre] (.../1296058257) (W2Ksp4)
{
GPU Accelerated Windows  0/1
}
This test fails on my Windows 2000 too.

***

Does Core support acceleration on Windows 2000/XP/2003 (and Linux)?

Fwiw, see "Hardware Acceleration by operating system" table at
http://hacks.mozilla.org/2010/09/hardware-acceleration/
status2.0: --- → ?
Assignee

Comment 8

9 years ago
Looking for early comments:
I'm not sure which exact platform acceleration is supported on :-/
I'll Try this patch, fwiw...
Attachment #507162 - Flags: feedback?(joe)
Comment on attachment 507162 [details] [diff] [review]
(Av1-WIPv1) Add missing 'var', Add/Improve checks

I'd prefer you didn't move the Windows_NT block down, because it makes hg annotate more complicated, but I don't feel super-strongly about it.
Attachment #507162 - Flags: feedback?(joe) → feedback+
Assignee

Comment 10

9 years ago
Av1-WIPv1, enhanced.

I'm still not 100% sure about which platforms are supposed to support which features,
but this rewrite succeeded on (Firefox) Try and it's just a mochitest.
At least, it's more explicit about the current expectations.


(In reply to comment #9)
> I'd prefer you didn't move the Windows_NT block down, because it makes hg
> annotate more complicated, but I don't feel super-strongly about it.

As I am +/- rewriting it all, I prefer to list the platform alphabetically.
Attachment #507162 - Attachment is obsolete: true
Attachment #507361 - Flags: review?(jmuizelaar)
Assignee

Comment 11

9 years ago
(In reply to comment #10)
> this rewrite succeeded on (Firefox) Try

Except on 'Maemo 5 opt' where mochi-3 suite doesn't start atm...
Assignee

Comment 12

9 years ago
(In reply to comment #6)
> What I'd like to know is whether acceleration is actually supported/enabled on
> these SeaMonkey builders (when running the browser manually for example)...

Justin, could you download and manually run a Firefox build on these builders and check <about:support>?
So you should find out whether the issue is in SM builds or boxes.
Summary: [SeaMonkey] mochitest-plain-3: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows too) → [SeaMonkey] mochitest-plain-3: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows 2003 too)
Can you please split up the functionality changes from the cosmetic ones, for ease of review?
Assignee

Comment 14

9 years ago
Av1, split up per comment 13.
Attachment #507361 - Attachment is obsolete: true
Attachment #507609 - Flags: review?(jmuizelaar)
Attachment #507361 - Flags: review?(jmuizelaar)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment on attachment 507609 [details] [diff] [review]
(Bv1) Add missing 'var', Sort os names alphabetically
[Checked in: Comment 26]

Not sure what the advantage of sorting the list alphabetically is. Seems like needless churn to me.
Attachment #507609 - Flags: review?(jmuizelaar) → review?(joe)
Assignee

Comment 17

9 years ago
Av1, split up per comment 13,
with added DWrite checks.

Ftr,
http://mxr.mozilla.org/mozilla-central/source/widget/public/nsIGfxInfo.idl
It might be interesting to use getFeatureStatus() (and other methods) to enhance the test and/or add further details (when a check fails).
Attachment #507620 - Flags: review?(jmuizelaar)
Attachment #507620 - Flags: review?(jmuizelaar) → review?(joe)
Assignee

Comment 18

9 years ago
(In reply to comment #2)
> Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test mochitests-3/5 on
> 2011/01/25 13:04:32
> 
> s: talos-r3-snow-014

(In reply to comment #4)
> A Firefox "random" is ("interesting" but) not this bug.
> (Unless the underlying issue could be explained.)

(In reply to comment #15)
> me%shawnwilsher.com
> Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central opt test mochitests-3/5 on
> 2011/01/27 13:11:48
> 
> s: talos-r3-snow-014

Something wrong with 'talos-r3-snow-014' box?

***

Still "not this bug" as a Firefox "random" test failure.

(In reply to comment #17)
> http://mxr.mozilla.org/mozilla-central/source/widget/public/nsIGfxInfo.idl
> It might be interesting to use getFeatureStatus() (and other methods) to
> enhance the test and/or add further details (when a check fails).

But this could be a hint/confirmation that current platform checks are not appropriate as a Core test, could it not?
(As in: if some runtime requirements are not met, the test should report a todo instead of a failure.)
Comment hidden (Legacy TBPL/Treeherder Robot)
Assignee

Updated

9 years ago
Depends on: 629598
Assignee

Comment 20

9 years ago
(In reply to comment #18)
> Something wrong with 'talos-r3-snow-014' box?

(In reply to comment #19)
> s: talos-r3-snow-014

I filed bug 629598.
Assignee

Updated

9 years ago
Depends on: 629616
Assignee

Comment 21

9 years ago
(In reply to comment #20)
> I filed bug 629598.

I filed bug 629616 to change screen resolution of SeaMonkey boxes...
Assignee

Comment 23

9 years ago
(Found when I searched for tests using nsIGfxInfo...)
Attachment #508170 - Flags: review?(bas.schouten)
Assignee

Updated

9 years ago
Depends on: 629957
Assignee

Comment 24

9 years ago
(In reply to comment #17)
> http://mxr.mozilla.org/mozilla-central/source/widget/public/nsIGfxInfo.idl
> It might be interesting to use getFeatureStatus() (and other methods) to
> enhance the test and/or add further details (when a check fails).

Related to this, I filed bug 629957.
Comment on attachment 507609 [details] [diff] [review]
(Bv1) Add missing 'var', Sort os names alphabetically
[Checked in: Comment 26]

I see no reason to sort the switch alphabetically, but I don't care much either.
Attachment #507609 - Flags: review?(joe) → review+
Attachment #507620 - Flags: review?(joe) → review+
Assignee

Comment 26

9 years ago
Comment on attachment 507609 [details] [diff] [review]
(Bv1) Add missing 'var', Sort os names alphabetically
[Checked in: Comment 26]

http://hg.mozilla.org/mozilla-central/rev/b7ca6147425e
Attachment #507609 - Attachment description: (Bv1) Add missing 'var', Sort os names alphabetically → (Bv1) Add missing 'var', Sort os names alphabetically [Checked in: Comment 26]
Assignee

Comment 27

9 years ago
Comment on attachment 507620 [details] [diff] [review]
(Cv1) Enhance existing checks, Add Windows 2000 check, Add Windows checks for DWrite, Add default case/check (for non-MacOSX non-Windows)
[Checked in: Comment 27]

http://hg.mozilla.org/mozilla-central/rev/3bb4b3a3189a
Attachment #507620 - Attachment description: (Cv1) Enhance existing checks, Add Windows 2000 check, Add Windows checks for DWrite, Add default case/check (for non-MacOSX non-Windows) → (Cv1) Enhance existing checks, Add Windows 2000 check, Add Windows checks for DWrite, Add default case/check (for non-MacOSX non-Windows) [Checked in: Comment 27]
Assignee

Comment 29

9 years ago
Ftr, udated logs:

OSX 10.6:
{
9820 ERROR TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X - didn't expect 0, but got it
}

Windows 2003:
{
9699 ERROR TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on Windows XP or newer - didn't expect 0, but got it
9700 INFO TEST-PASS | /tests/gfx/test_acceleration.html | Direct2D not supported on Windows 2003 or older
9701 INFO TEST-PASS | /tests/gfx/test_acceleration.html | DirectWrite not supported on Windows 2003 or older
}
Assignee

Comment 30

9 years ago
Comment on attachment 508169 [details] [diff] [review]
(Dv1) test_selection_underline.html: Move waitForExplicitFinish() out of onLoad(), Make existing todo() more explicit
[Checked in: Comment 30]

http://hg.mozilla.org/mozilla-central/rev/ee7c16ea0e60

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/38b8e1b2c1b8
(Fv1-192) test_selection_underline.html: Move waitForExplicitFinish() out of onLoad(), Make existing todo() more explicit
Attachment #508169 - Attachment description: (Dv1) test_selection_underline.html: Move waitForExplicitFinish() out of onLoad(), Make existing todo() more explicit → (Dv1) test_selection_underline.html: Move waitForExplicitFinish() out of onLoad(), Make existing todo() more explicit [Checked in: Comment 30]
Assignee

Updated

8 years ago
Blocks: 634581
Comment hidden (Legacy TBPL/Treeherder Robot)
Assignee

Comment 32

8 years ago
(In reply to comment #31)
> david.bolter%gmail.com
> http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1299269077.1299269462.21175.gz

Still "not this bug" as a Firefox "random" test failure!
Comment hidden (Legacy TBPL/Treeherder Robot)
Assignee

Updated

8 years ago
Blocks: 653481
Assignee

Comment 34

8 years ago
Ev1, unbitrotted.
Attachment #508170 - Attachment is obsolete: true
Attachment #582549 - Flags: review?(jmuizelaar)
Attachment #508170 - Flags: review?(bas.schouten)
Comment on attachment 582549 [details] [diff] [review]
(Ev1a) test_canvas.html: s/tab/4-spaces/g, Call IsD2DEnabled() once only, Add a todo() when Direct2D is enabled

Do these indentation changes move us closer or further from upstream?
Assignee

Comment 36

8 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #35)
> Do these indentation changes move us closer or further from upstream?

I didn't know there was an upstream for this test(s). What/Where is it?
(In reply to Serge Gautherie (:sgautherie) from comment #36)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #35)
> > Do these indentation changes move us closer or further from upstream?
> 
> I didn't know there was an upstream for this test(s). What/Where is it?

http://philip.html5.org/tests/canvas/suite/tests/

Also see bug 703488
Assignee

Updated

8 years ago
Blocks: 712216
Assignee

Comment 38

8 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #37)
> > (In reply to Jeff Muizelaar [:jrmuizel] from comment #35)
> > > Do these indentation changes move us closer or further from upstream?
> 
> http://philip.html5.org/tests/canvas/suite/tests/

Hum, all tests were merged into one in m-c...

I tried to compare test_2d.clearRect.basic.html,
but http://philip.html5.org/tests/canvas/suite/tests/2d.clearRect.basic.html source code
looks "completely" different from the one in m-c :-/

> Also see bug 703488

Maybe that bug should be done first...

Yet, if you would accept my patch without the indentation changes, that would be good enough for this bug. Would you?

While there, I think a reference to upstream should be added to m-c file, should it not?
Assignee

Updated

8 years ago
status2.0: ? → ---
OS: Mac OS X → All
Hardware: x86_64 → All
Comment on attachment 588328 [details] [diff] [review]
(Fv1 (bis)) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration

Definitely don't want the (acceleratedWindows == 0) condition. I think whatever we do should be only on SeaMonkey.

Also, we probably want an actual test here, so when switching machines we verify that something has changed. So it could be

if (navigator.userAgent.match(/ SeaMonkey\//)) {
  is(acceleratedWindows, 0, "Acceleration not supported on x86-64 OS X" +
                            " (This is expected on SeaMonkey (tinderboxes).)");
} else {
  isnot(acceleratedWindows, 0, "Acceleration enabled on x86-64 OS X");
}
Attachment #588328 - Flags: review?(joe) → review-
Assignee

Comment 41

8 years ago
Fv1, with comment 40 suggestion(s).


(In reply to Joe Drew (:JOEDREW!) from comment #40)

> Definitely don't want the (acceleratedWindows == 0) condition. I think
> whatever we do should be only on SeaMonkey.

Agreed.

> Also, we probably want an actual test here, so when switching machines we
> verify that something has changed.

That was exactly what I had done in the first place ;->
But, on one hand, new machines would only happen once (if ever): new behavior can be manually checked at that very time and workaround wouldn't hurt anyway;
whereas, on the other hand, no actual test lets local testers (if any) check the full test (if they have a supported environment) :-| (Pros and cons...)
Assignee: nobody → sgautherie.bz
Attachment #588328 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #588587 - Flags: review?(joe)
Assignee

Updated

8 years ago
Attachment #588587 - Attachment filename: 628589-Fv1_SeaMonkey.diff → 628589-Fv2_SeaMonkey.diff
Assignee

Updated

8 years ago
Priority: -- → P2
Attachment #588587 - Flags: review?(joe) → review+
Assignee

Comment 42

8 years ago
Comment on attachment 588587 [details] [diff] [review]
(Fv2) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration
[Checked in: Comments 42 and 46]

https://hg.mozilla.org/mozilla-central/rev/42a133039277


[Approval Request Comment]
Regression caused by (bug #): bug 627498.
User impact if declined: none, but perma-orange mochi-4 on SeaMonkey (due to this very test only).
Testing completed (on m-c, etc.): this comment.
Risk to taking this patch (and alternatives if risky): No risk, test-only SeaMonkey workaround.
Attachment #588587 - Attachment description: (Fv2) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration → (Fv2) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration [Checked in: Comment 42]
Attachment #588587 - Flags: approval-mozilla-beta?
Attachment #588587 - Flags: approval-mozilla-aurora?
Assignee

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
No longer depends on: 629616, 629598
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Assignee

Comment 43

8 years ago
Comment on attachment 588328 [details] [diff] [review]
(Fv1 (bis)) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration

Oh, there was already a patch named 'Fv1' in comment 28+30 :-/
Attachment #588328 - Attachment description: (Fv1) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration → (Fv1 (bis)) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration
Assignee

Comment 44

8 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1326800207.1326801067.649.gz
OS X 10.6 comm-central-trunk debug test mochitests-4/5 on 2012/01/17 03:36:47
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1326791848.1326794814.20843.gz
WINNT 5.2 comm-central-trunk debug test mochitests-4/5 on 2012/01/17 01:17:28

V.Fixed
Status: RESOLVED → VERIFIED
Summary: [SeaMonkey] mochitest-plain-3: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows 2003 too) → [SeaMonkey] mochitest-plain-4: permanent "TEST-UNEXPECTED-FAIL | /tests/gfx/test_acceleration.html | Acceleration enabled on x86-64 OS X". (Windows 2003 too)
Whiteboard: [perma-orange] → [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 12a1: Fv2] [perma-orange]
Comment on attachment 588587 [details] [diff] [review]
(Fv2) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration
[Checked in: Comments 42 and 46]

[Triage Comment]
Test only - approved for aurora/beta.
Attachment #588587 - Flags: approval-mozilla-beta?
Attachment #588587 - Flags: approval-mozilla-beta+
Attachment #588587 - Flags: approval-mozilla-aurora?
Attachment #588587 - Flags: approval-mozilla-aurora+
Assignee

Updated

8 years ago
Keywords: checkin-needed
Whiteboard: [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 12a1: Fv2] [perma-orange] → [c-n: patch Fv2 to m-a and m-b] [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 12a1: Fv2] [perma-orange]
Assignee

Updated

8 years ago
Whiteboard: [c-n: patch Fv2 to m-a and m-b] [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 12a1: Fv2] [perma-orange] → [c-n: patch Fv2 to m-b] [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 12a1: Fv2] [perma-orange]
Comment on attachment 588587 [details] [diff] [review]
(Fv2) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration
[Checked in: Comments 42 and 46]

http://hg.mozilla.org/releases/mozilla-beta/rev/afcb5dfe30eb
Attachment #588587 - Attachment description: (Fv2) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration [Checked in: Comment 42] → (Fv2) test_acceleration.html: Add a workaround for SeaMonkey (tinderboxes) which don't support acceleration [Checked in: Comments 42 and 46]
Keywords: checkin-needed
Whiteboard: [c-n: patch Fv2 to m-b] [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 12a1: Fv2] [perma-orange] → [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 11b5: Fv2] [perma-orange]
Whiteboard: [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 11b5: Fv2] [perma-orange] → [fixed in 1.9.2(FFv3.6.17): Fv1-192; 2.0b11: Bv1, Cv1, Dv1, Fv1; 11b5: Fv2] [perma-orange][qa-]
Assignee

Comment 47

7 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1329966089.1329968490.29674.gz
OS X 10.6 comm-beta debug test mochitests-4/5 on 2012/02/22 19:01:29

firefox11: verified.
Comment on attachment 582549 [details] [diff] [review]
(Ev1a) test_canvas.html: s/tab/4-spaces/g, Call IsD2DEnabled() once only, Add a todo() when Direct2D is enabled

Review of attachment 582549 [details] [diff] [review]:
-----------------------------------------------------------------

I expect this has rotted a great deal. It also mixed cosmetic changes with functional ones.
Attachment #582549 - Flags: review?(jmuizelaar) → review-
You need to log in before you can comment on or make changes to this bug.