630157 - double clicking anywhere in a group with any mouse button creates new tabs

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

New tabs shouldn't be created when:

1) clicking with other than the left mouse button.
2) clicking on the titlebar.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 508366 [details] [diff] [review]
patch v1

>+      if (self.$titlebar[0] === e.target || self.$titlebar.contains(e.target))
>+        return;

=== isn't useful here, please use == instead.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

(In reply to comment #2)
> >+      if (self.$titlebar[0] === e.target || self.$titlebar.contains(e.target))
> >+        return;
> 
> === isn't useful here, please use == instead.

You're right, I forgot about that. Fixed.

Comment 4

[Ian Gilman [:iangilman]]

Comment on attachment 508370 [details] [diff] [review]
patch v2

lovely :-)

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Passed try after correcting small parts of the test. Do I need to request review/approval again?

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]&rev=eeb9f6b254a9

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #5)
> Passed try after correcting small parts of the test. Do I need to request
> review/approval again?
It doesn't hurt to do so.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 509369 [details] [diff] [review]
patch for checkin

Requesting review again because a small part of the test had to be fixed to pass try.

Comment 8

[Ian Gilman [:iangilman]]

Comment on attachment 509369 [details] [diff] [review]
patch for checkin

The change looks good.

Comment 9

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/e8ad36c57a90

Comment 10

[Tracy Walker [:tracy]]

verified with recent minefield nightly build