Closed Bug 630157 Opened 10 years ago Closed 10 years ago

double clicking anywhere in a group with any mouse button creates new tabs

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file, 2 obsolete files)

New tabs shouldn't be created when:

1) clicking with other than the left mouse button.
2) clicking on the titlebar.
Summary: double clicking anywhere in a group with any mouse buttons creates new tabs → double clicking anywhere in a group with any mouse button creates new tabs
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #508366 - Flags: review?(ian)
Comment on attachment 508366 [details] [diff] [review]
patch v1

>+      if (self.$titlebar[0] === e.target || self.$titlebar.contains(e.target))
>+        return;

=== isn't useful here, please use == instead.
Attached patch patch v2 (obsolete) — Splinter Review
(In reply to comment #2)
> >+      if (self.$titlebar[0] === e.target || self.$titlebar.contains(e.target))
> >+        return;
> 
> === isn't useful here, please use == instead.

You're right, I forgot about that. Fixed.
Attachment #508370 - Flags: review?(ian)
Attachment #508366 - Attachment is obsolete: true
Attachment #508366 - Flags: review?(ian)
Comment on attachment 508370 [details] [diff] [review]
patch v2

lovely :-)
Attachment #508370 - Flags: review?(ian) → review+
Attachment #508370 - Flags: approval2.0?
Attachment #508370 - Flags: approval2.0? → approval2.0+
Passed try after correcting small parts of the test. Do I need to request review/approval again?

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=eeb9f6b254a9
Attachment #508370 - Attachment is obsolete: true
(In reply to comment #5)
> Passed try after correcting small parts of the test. Do I need to request
> review/approval again?
It doesn't hurt to do so.
Comment on attachment 509369 [details] [diff] [review]
patch for checkin

Requesting review again because a small part of the test had to be fixed to pass try.
Attachment #509369 - Flags: review?(ian)
Comment on attachment 509369 [details] [diff] [review]
patch for checkin

The change looks good.
Attachment #509369 - Flags: review?(ian) → review+
Attachment #509369 - Flags: approval2.0?
Attachment #509369 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/e8ad36c57a90
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
verified with recent minefield nightly build
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.