Closed Bug 630270 Opened 10 years ago Closed 10 years ago

Port |Bug 628198 - Implement UI for do-not-track HTTP header| to SeaMonkey

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b2

People

(Reporter: InvisibleSmiley, Assigned: adriank)

References

Details

Attachments

(1 file)

Bug 628198 added UI for the privacy.donottrackheader.enabled pref to Firefox. I think we should add it as well, but possibly at a different place.

Firefox has it now under Advanced/General/Browsing. The list of checkboxes there mostly relates to our Appearance/Content.

I propose that we add it somewhere under Privary & Security because that's where it fits best. Since it doesn't really fit with the subcategories I propose we add it to the main pane, e.g. as the very first checkbox, under Private Data. It's not 100% related but IMHO good enough.

The label could be the same as in Firefox: "Tell web sites I do not want to be tracked".

Since this is probably a small change I further propose we add the Help entry at the same time, which will not only save us filing an extra bug but also having to find someone to actually write a patch for that other bug and get it reviewed.
> I propose that we add it somewhere under Privary & Security because that's
> where it fits best. Since it doesn't really fit with the subcategories I
> propose we add it to the main pane, e.g. as the very first checkbox, under
> Private Data. It's not 100% related but IMHO good enough.

That's almost exactly Alex Faaborgs proposal in attachment 506496 [details] in Bug 628198.
See bug 628198 comment 16.
I already mentioned this in #seamonkey. Too bad the logs are MIA.
Not sure who is the right person to ask for review here, so if it is not you Robert, let someone else please review the patch.
Assignee: nobody → akalla
Status: NEW → ASSIGNED
Attachment #509163 - Flags: review?
Attachment #509163 - Flags: review? → review?(kairo)
Attachment #509163 - Flags: review?(kairo) → review?(iann_bugzilla)
> +      <!-- Do Not Track -->
> +      <preference id="privacy.donottrackheader.enabled"
Reduntant comment since the strings do not track already appear in the preference name.

> +    <!-- Do Not Track -->
> +    <groupbox id="doNotTrackGroup">

> +        <checkbox id="privacyDoNotTrackPrefs"
We seem to have flex="1" on the other checkboxes.
Comment on attachment 509163 [details] [diff] [review]
patch v1 (based on the Firefox patch from Bug 628198) [Checked in: Comment 6]

The comments can stay but as Philip suggested:
> +        <checkbox id="privacyDoNotTrackPrefs"
We seem to have flex="1" on the other checkboxes.

r=me with that fixed.
Attachment #509163 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 509163 [details] [diff] [review]
patch v1 (based on the Firefox patch from Bug 628198) [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/d1458229a862
Attachment #509163 - Attachment description: patch v1 (based on the Firefox patch from Bug 628198) → patch v1 (based on the Firefox patch from Bug 628198) [Checked in: Comment 6]
Was checked in with flex="1" added.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
The flex is needed for the checkbox to be able to wrap should other locales need more than one line of text. <vbox align="start"> is another approach.
Target Milestone: --- → seamonkey2.1b2
(In reply to comment #0)
> Since this is probably a small change I further propose we add the Help entry
> at the same time, which will not only save us filing an extra bug but also
> having to find someone to actually write a patch for that other bug and get it
> reviewed.

Not done here. Was another bug filed?
No longer blocks: FF2SM
Blocks: 631566
(In reply to comment #9)
> Was another bug filed?

No, filed bug 631566.
Blocks: 631639
Depends on: 628198
You need to log in before you can comment on or make changes to this bug.