630270 - Port |Bug 628198 - Implement UI for do-not-track HTTP header| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Bug 628198 added UI for the privacy.donottrackheader.enabled pref to Firefox. I think we should add it as well, but possibly at a different place.

Firefox has it now under Advanced/General/Browsing. The list of checkboxes there mostly relates to our Appearance/Content.

I propose that we add it somewhere under Privary & Security because that's where it fits best. Since it doesn't really fit with the subcategories I propose we add it to the main pane, e.g. as the very first checkbox, under Private Data. It's not 100% related but IMHO good enough.

The label could be the same as in Firefox: "Tell web sites I do not want to be tracked".

Since this is probably a small change I further propose we add the Help entry at the same time, which will not only save us filing an extra bug but also having to find someone to actually write a patch for that other bug and get it reviewed.

Comment 1

[Philip Chee]

> I propose that we add it somewhere under Privary & Security because that's
> where it fits best. Since it doesn't really fit with the subcategories I
> propose we add it to the main pane, e.g. as the very first checkbox, under
> Private Data. It's not 100% related but IMHO good enough.

That's almost exactly Alex Faaborgs proposal in attachment 506496 [details] in Bug 628198.
See bug 628198 comment 16.

Comment 2

[Philip Chee]

I already mentioned this in #seamonkey. Too bad the logs are MIA.

Comment 3

[Adrian Kalla [:adriank]]

Attachment: patch v1 (based on the Firefox patch from Bug 628198) [Checked in: Comment 6]

Not sure who is the right person to ask for review here, so if it is not you Robert, let someone else please review the patch.

Comment 4

[Philip Chee]

> +      <!-- Do Not Track -->
> +      <preference id="privacy.donottrackheader.enabled"
Reduntant comment since the strings do not track already appear in the preference name.

> +    <!-- Do Not Track -->
> +    <groupbox id="doNotTrackGroup">

> +        <checkbox id="privacyDoNotTrackPrefs"
We seem to have flex="1" on the other checkboxes.

Comment 5

[Ian Neal]

Comment on attachment 509163 [details] [diff] [review]
patch v1 (based on the Firefox patch from Bug 628198) [Checked in: Comment 6]

The comments can stay but as Philip suggested:
> +        <checkbox id="privacyDoNotTrackPrefs"
We seem to have flex="1" on the other checkboxes.

r=me with that fixed.

Comment 6

[Ian Neal]

Comment on attachment 509163 [details] [diff] [review]
patch v1 (based on the Firefox patch from Bug 628198) [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/d1458229a862

Comment 7

[Ian Neal]

Was checked in with flex="1" added.

Comment 8

[[e-mail]]

The flex is needed for the checkbox to be able to wrap should other locales need more than one line of text. <vbox align="start"> is another approach.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> Since this is probably a small change I further propose we add the Help entry
> at the same time, which will not only save us filing an extra bug but also
> having to find someone to actually write a patch for that other bug and get it
> reviewed.

Not done here. Was another bug filed?

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #9)
> Was another bug filed?

No, filed bug 631566.