Closed Bug 631566 Opened 9 years ago Closed 7 years ago

Document the main Privacy & Security pref pane and add a Help button to it

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.19

People

(Reporter: InvisibleSmiley, Assigned: rsx11m.pub)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 4 obsolete files)

The main Privacy & Security pref pane has no Help button. Oops. Also its contents are not documented, namely the sanitize options (for which bug 416234 already exists) and the new Do-Not-Track checkbox introduced through bug 630270. This bug and/or bug 416234 need to make sure that the whole pane as it is now ends up being documented and featuring a Help button.
Attachment #509805 - Flags: review?(iann_bugzilla)
Attachment #509805 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 509805 [details] [diff] [review]
Part 1: add Help button [Checkin: comment 2]

http://hg.mozilla.org/comm-central/rev/65aed01a5b8d
Attachment #509805 - Attachment description: add Help button → add Help button [Checkin: comment 2]
Leaving open for the actual Help changes.
Blocks: 636993
I think the pref pane documentation has priority over documenting sanitizing / Clear Private Data in general, thus moving bug 416234 to list of bugs blocked by this one.
Blocks: 416234, 553652
No longer depends on: 416234
Depends on: 835134
No longer blocks: 553652
Bug 835134 splits a new Private Data pane off the main Privacy & Policy pane, extends the "Do Not Track" options per bug 765398, and adds "Safe Browsing" options per bug 477718.

Firefox points to https://www.mozilla.org/dnt for help content of the tracking options. While that's a Firefox-specific site with respect to the preferences and settings, it contains some useful information on the "Do Not Track" options as such which should go into the help content.

See some suggestions in bug 835134 comment #14 and following for longer labels on the safe browsing options, which should provide some more information that may be useful for the related help content.

Some coordination with bug 416234 will be necessary with regard to the options in the new Private Data pane, which is a superset of the menu-based options.
Bug 835134 attachment 709466 [details] [diff] [review] adds a help topic for the new Private Data pane that needs to be wired, helpTopic="privatedata_prefs".
No longer blocks: 416234
Depends on: 416234
Status: NEW → ASSIGNED
QA Contact: rsx11m.pub
Assignee: nobody → rsx11m.pub
QA Contact: rsx11m.pub
Suggested drive-by fix: For the individual subpanels, privsec_help.html points for some items directly to the preferences description, for others to the introductory section. Since this help item is about the pref panes specifically, I'd suggest to also point for those items directly to the preferences sections.
Also, with respect to suite-toc.rdf, it appears that Privacy & Security is the only category which doesn't have a submenu providing direct access to the subpanes of that category. I'd add those unless this omission was intentional.
Memo to myself for yet another drive-by fix: http://mxr.mozilla.org/comm-central/source/suite/locales/en-US/chrome/common/help/certs_prefs_help.xhtml#41 uses <h1> for the "Privacy &amp; Security Preferences - Certificates" heading, which should be <h2> instead like the other preference pane headings.
Attached patch Part 2: Content and linking (obsolete) — Splinter Review
Here comes the third and final installment of the trilogy... ;-)

certs_prefs_help.xhtml: Covers comment #9 (<h2> vs. <h1>)

help-index1.rdf: Adds topics for "safe browsing" and "user tracking" so that the help search provides respective hits to the preferences page. 

privsec_help.xhtml: Covers comment #7, followed by the main text additions.

suite-toc.rdf: Covers comment #8 with properly wired subpanel links.

The main Privacy & Security pane in privsec_help.xhtml is split into two <h3> sections following the examples in the Images, Passwords, and other subpanels with multiple groups. I had them both in a single section first, which looked overly long; on the other hand, the feature descriptions aren't long enough to warrant their own sections, thus the proposed structure is the best way I could find to present this and hopefully ok.

The text is a partial adaption from the Firefox KB, https://support.mozilla.org/en-US/kb/how-do-i-turn-do-not-track-feature and https://support.mozilla.org/en-US/kb/security-and-passwords-settings along with some own contributions.

This patch applies against current trunk and may be bitrotted by some of the other patches (specifically bug 416234) I currently have pending for review.
Attachment #716350 - Flags: review?(iann_bugzilla)
Eh, spell checker found three typos which I'll correct with the next patch:

> -<p>These preferences allows you to select which types of reported websites
> +<p>These preferences allow you to select which types of reported websites

> -    frequently immitate legitimate websites of well known organizations.</li>
> +    frequently imitate legitimate websites of well-known organizations.</li>
Attachment #509805 - Attachment description: add Help button [Checkin: comment 2] → Part 1: add Help button [Checkin: comment 2]
Attachment #716350 - Attachment description: Proposed patch → Part 2: Content and linking
(Quoting Philip Chee from bug 844098)
> Bug Bug 477718 implemented Safe Browsing in SeaMonkey. [...]
> Toolkit Bug 514817 has some useful strings we can adapt from

> <!ENTITY rights.safebrowsing-b "Disabling the Safe Browsing feature is not
> recommended as it may result in you going to unsafe sites.  If you wish to
> disable the feature completely, follow these steps:">

The first sentence of this entity should fit well at the end of the introduction to the Safe Browsing section to make people think before unticking the boxes, maybe even as a separate paragraph before the <ul> listing.
Attached patch Part 2: Content and linking (v2) (obsolete) — Splinter Review
Addressed comment #11 and comment #12.
Attachment #716350 - Attachment is obsolete: true
Attachment #716350 - Flags: review?(iann_bugzilla)
Attachment #717128 - Flags: review?(iann_bugzilla)
(In reply to rsx11m from comment #10)
> the feature descriptions aren't long enough to warrant their own sections,

After watching the presentation by Gary Kovacs on TED.com (linked to from the Firefox site for "Do Not Track") I'm tempted to change my mind on this. The user tracking stuff has indeed reached scary dimensions and it seems this should be addressed at least to some extent. I think this is beyond the scope of this bug on the pref pane documentation, given that it may open a few cans of worms (not just for the discussion on benefits vs. dangers of tracking, also with respect on how to effectively reducing it, which likely won't work just with DNT and cookie settings but also would have to include add-ons like ABP, assuming that they block tracking along with the underlying ad placements). Thus, I'll spin off a follow-up bug once we are done here to extent privacy_help.xhtml with a general discussion.
Blocks: 844823
Attached patch Part 2: Content and linking (v3) (obsolete) — Splinter Review
Unbitrotted after today's bug 416234 landing.

I've also made a minor change for the target of "safe browsing" in the help index. It was previously pointing to the start of the pref pane description, thus needing quite a bit of scrolling down before actually getting to the <h3> Safe Browsing subsection. Now, the link points directly to the section heading, and I've added an upwards-link to the description how to open the pane.

No other changes relative to attachment 717128 [details] [diff] [review].
Attachment #717128 - Attachment is obsolete: true
Attachment #717128 - Flags: review?(iann_bugzilla)
Attachment #718206 - Flags: review?(iann_bugzilla)
Attachment #718206 - Attachment description: Proposed patch (v3) → Part 2: Content and linking (v3)
Comment on attachment 718206 [details] [diff] [review]
Part 2: Content and linking (v3)

>+++ b/suite/locales/en-US/chrome/common/help/privsec_help.xhtml

>+<p>These preferences in the <a href="#privacy_and_security">Privacy &amp;
>+  Security panel</a> allow you to select which types of reported websites
>+  with potentially dangerous content are to be blocked. If enabled,
This sounds slightly awkward, at the minimum it is missing some punctuation.

>+  &brandShortName; compares each website&apos;s address you are about to visit
>+  against regularly downloaded lists. A warning is issued prior to actually
Maybe "updated" rather than "downloaded"?

>+<p><strong>Important</strong>: The Safe Browsing feature is switched on by
>+  default. It is <em>not</em> recommended to disable either function as this
>+  may result in you going to unsafe sites.</p>
Perhaps "visiting" rather than "going to"

f+ for the moment, thanks for the good work.
Attachment #718206 - Flags: review?(iann_bugzilla) → feedback+
Attached patch Part 2: Content and linking (v4) (obsolete) — Splinter Review
(In reply to Ian Neal from comment #16)
> >+<p>These preferences in the <a href="#privacy_and_security">Privacy &amp;
> >+  Security panel</a> allow you to select which types of reported websites
> >+  with potentially dangerous content are to be blocked. If enabled,
> This sounds slightly awkward, at the minimum it is missing some punctuation.

That's a typical sentence which started out as a 1-liner and then kept growing. ;-)

I've split it and put the explanation of malicious websites being reported upfront, then getting to the related settings. This hopefully makes more sense.

> >+  &brandShortName; compares each website&apos;s address you are about to visit
> >+  against regularly downloaded lists. A warning is issued prior to actually
> Maybe "updated" rather than "downloaded"?

Done - agreed, that it's kept up to date is the main point.

> >+<p><strong>Important</strong>: The Safe Browsing feature is switched on by
> >+  default. It is <em>not</em> recommended to disable either function as this
> >+  may result in you going to unsafe sites.</p>
> Perhaps "visiting" rather than "going to"

That was actually the wording Firefox uses, but "visiting" fits certainly better.
Attachment #718206 - Attachment is obsolete: true
Attachment #720304 - Flags: review?(iann_bugzilla)
Per bug 599097 comment #4, this adds the missing "Popup Windows" links.
Attachment #720304 - Attachment is obsolete: true
Attachment #720304 - Flags: review?(iann_bugzilla)
Attachment #720309 - Flags: review?(iann_bugzilla)
Attachment #720304 - Attachment is patch: true
Attachment #720309 - Flags: review?(iann_bugzilla) → review+
Thanks, push for attachment 720309 [details] [diff] [review] on trunk please.
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
https://hg.mozilla.org/comm-central/rev/8a14d431ec6d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → seamonkey2.19
Attachment #720309 - Attachment description: Part 2: Content and linking (v5) → Part 2: Content and linking (v5) [Checkin: comment 20]
Blocks: 847182
Blocks: 852809
You need to log in before you can comment on or make changes to this bug.