630330 - Windows theme swaps "Drafts" and "Templates" icons

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Jim Porter (:squib)]

... well, or the Linux theme does, since the two are inconsistent.

In the Windows theme, the "drafts" icon is the little sheet of paper with a pyramid of dots, and the "templates" icon is the little sheet of paper with writing on it. In Linux, these are reversed. One of these is probably wrong, and I'm leaning towards Windows being the one in error, since 1) the paper with writing seems more "draft-y" to me, and 2) it looks closer to the drafts icon on Mac.

Comment 1

[rsx11m]

If I compare the versions in folder.png vs. folder-aero.png, the squared piece
of paper with some written lines in it seems to be used for Drafts in the aero version, and there is no pyramid-like (Draft-XP) icon. Instead, template is an empty piece of paper. So at least the paper-with-lines icon appears switched.

Comment 2

[Jim Porter (:squib)]

Attachment: Fix the icons in Windows XP

Here's a patch for this. It should be pretty straightforward. :)

Comment 3

[rsx11m]

Jim, folderPane.css is included by folderPane-aero.css, so this would also swap the icons for Vista and Windows 7 (where they are as intended - are they?). Thus, either the icons in folder.png need to be switched or the rules to differ between folderPane.css and folderPane-aero.css, the latter staying the current.

Comment 4

[Jim Porter (:squib)]

I'm actually not sure that the icons are in a different order on Vista compared to XP. Maybe they are, maybe they aren't.

Comment 5

[rsx11m]

Well, the icons are different, I'm not sure about their order either... :-)

Comment 6

[Andreas Nilsson (:andreasn)]

(In reply to comment #2)
> Created attachment 526643 [details] [diff] [review] [review]
> Fix the icons in Windows XP
> 
> Here's a patch for this. It should be pretty straightforward. :)

I don't have a XP build. Could you post before and after screenshots?
I'm leaning towards fixing the graphics instead, since it would be good to have them sync up.

Comment 7

[Andreas Nilsson (:andreasn)]

Attachment: icons

This patch makes the icon for Aero a look closer to the other draft icons and swaps the place for the draft and template icon for XP.

Comment 8

[Jim Porter (:squib)]

The new patch seems alright by me (though I don't have a Windows build set up to test it out on).

Comment 9

[Jim Porter (:squib)]

Comment on attachment 530037 [details] [diff] [review]
icons

Blake, do you mind taking a look at this? It's pretty simple, but I'm not totally sure I could just r+ it myself. Don't feel any huge rush to do this though, since this doesn't affect l10n and isn't a feature, so it could probably get checked in after string freeze.

Comment 10

[Jim Porter (:squib)]

Well, ok, I *could* r+ it myself, but I'm not sure I *should*. :)

Comment 11

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 530037 [details] [diff] [review]
icons

>diff --git a/mail/themes/qute/mail/icons/folder-aero.png b/mail/themes/qute/mail/icons/folder-aero.png
>index ceeef7fc3a29202c4b3e79191a3b3b98a405ecd3..8e997d2642442ea307583a644586754fa4098e34
>GIT binary patch
>literal 6311
[snip…]
>za9>q_bLyS1TEg|Z<3w{$MbWlhRmw!C`+Pa`G2|FbNNb%drK}K$RD%i3`t}ce&%N*;

I think that should have been "MbWlbRmw"…  ;)

Just kidding.  This makes sense to me, let's do it.  :)

Thanks,
Blake.

Comment 12

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/1b2874078e12

Comment 13

[Jim Porter (:squib)]

Comment on attachment 530037 [details] [diff] [review]
icons

Should this go into 3.3? It seems pretty innocuous.

Comment 14

[Mark Banner (:standard8)]

Comment on attachment 530037 [details] [diff] [review]
icons

Getting icons the right way round is definitely a good idea I think.

Comment 15

[Jonathan Protzenko [:protz]]

https://bugzilla.mozilla.org/show_bug.cgi?id=630330

Comment 16

[Jonathan Protzenko [:protz]]

meant http://hg.mozilla.org/releases/comm-miramar/file/bb43a121dd9a, sorry