630462 - [SeaMonkey] mochitest-browser-chrome: permanent failures in browser_purchase.js ("Got about:addons, expected http://example.com/browser/...", etc)

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Serge Gautherie (:sgautherie)]

Linux and Windows are affected, OSX is not :-|
I can reproduce on my Windows 2000.

{
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_purchase.js | Should have loaded the right page - Got about:addons, expected http://example.com/browser/toolkit/mozapps/extensions/test/browser/releaseNotes.xhtml?addon4
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_purchase.js | Should be back to the add-ons manager - Got about:blank, expected about:addons
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_purchase.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_purchase.js | Should not have seen an install of http://example.com/addon1.xpi in state 0
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_purchase.js | Found a tab after previous test timed out: http://example.com/browser/toolkit/mozapps/extensions/test/browser/releaseNotes.xhtml?addon4
}

Comment 1

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> Linux and Windows are affected, OSX is not :-|

Hum, it looks like OSX 10.5 does fail too, whereas OSX 10.16 passes :-:
Anyway.

Comment 2

[Serge Gautherie (:sgautherie)]

Code is:
{
// Tests that clicking the buy button from the details view works
add_test(function() {
  gBrowser.addEventListener("load", function() {
    if (gBrowser.currentURI.spec == "about:blank")
      return;
    gBrowser.removeEventListener("load", arguments.callee, true);

    is(gBrowser.currentURI.spec, TESTROOT + "releaseNotes.xhtml?addon4", "Should have loaded the right page");
}

This failure is odd: it seems gBrowser.currentURI.spec changes during callback execution :-(

Comment 3

[[e-mail]]

Attachment: Proposed patch

So, our tabbrowsers have some minor differences and while we don't fire the about:blank that you're trying to avoid we do fire a different about:blank!

Comment 4

[[e-mail]]

Comment on attachment 508720 [details] [diff] [review]
Proposed patch

Bah, typoed your name, please read comment #3 kthxbye

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 508720 [details] [diff] [review]
Proposed patch

>-  gBrowser.addEventListener("load", function() {
>-    if (gBrowser.currentURI.spec == "about:blank")
>+  gBrowser.addEventListener("load", function(event) {
>+    if (event.target.location.href == "about:blank")

You'll need to do the same for the other case where the tests checks this too.

(I assume you've tested this on a Firefox build, and/or run it through TryServer)

Comment 6

[[e-mail]]

Attachment: Updated patch [Checked in: Comment 9]

Comment 7

[[e-mail]]

Comment on attachment 509782 [details] [diff] [review]
Updated patch
[Checked in: Comment 9]

Passes on both my local Firefox and SeaMonkey builds.

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 509782 [details] [diff] [review]
Updated patch
[Checked in: Comment 9]

Sorry for the delay - was off sick.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 509782 [details] [diff] [review]
Updated patch
[Checked in: Comment 9]

http://hg.mozilla.org/mozilla-central/rev/2ce5e1843ce8

Comment 10

[Serge Gautherie (:sgautherie)]

Still this bug as reported:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1296824378.1296829595.24188.gz
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2011/02/04 04:59:38
{
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_purchase.js | Should have loaded the right page - Got about:addons, expected http://example.com/browser/toolkit/mozapps/extensions/test/browser/releaseNotes.xhtml?addon4
}

New error(s), see bug 632396:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1296847508.1296852650.24834.gz
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2011/02/04 11:25:08
{
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_purchase.js | Should be 5 results - Got 1, expected 5
...
}

This bug can't be verified atm as it made no difference yet :-/
Let's wait for bug 632396!

Comment 11

[Serge Gautherie (:sgautherie)]

The test passes, but:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1297485532.1297489043.18251.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2011/02/11 20:38:52
{
JavaScript strict warning: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_purchase.js, line 140: reference to undefined property event.target.location
JavaScript error: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_purchase.js, line 140: event.target.location is undefined
JavaScript strict warning: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_purchase.js, line 140: reference to undefined property event.target.location
JavaScript error: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_purchase.js, line 140: event.target.location is undefined
...
JavaScript strict warning: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_purchase.js, line 164: reference to undefined property event.target.location
JavaScript error: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_purchase.js, line 164: event.target.location is undefined
JavaScript strict warning: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_purchase.js, line 164: reference to undefined property event.target.location
JavaScript error: chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_purchase.js, line 164: event.target.location is undefined
}

Comment 12

[[e-mail]]

Attachment: Only listen to document loads [Checked in: Comment 14]

Looks like the test bogusly failed to look for the actual document load :-(

Comment 13

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 511957 [details] [diff] [review]
Only listen to document loads
[Checked in: Comment 14]

Your about:blank is weird :)

Comment 14

[[e-mail]]

Pushed changeset acda9a0a6c6f to mozilla-central.

Comment 15

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1297896528.1297900353.15666.gz&fulltext=1
Rev3 WINNT 6.1 mozilla-central debug test mochitest-other on 2011/02/16 14:48:48

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1297890609.1297893535.22210.gz&fulltext=1
OS X 10.6 comm-central-trunk debug test mochitest-other on 2011/02/16 17:23:43

V.Fixed.