630484 - Properly support plural forms in advance search dialog status message

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I noticed a while back that the 1 match found/n matches found status message in the advanced search dialog doesn't properly support plural forms.

We should fix that, attaching a patch.

Comment 1

[Rain [:rain1] (inactive)]

Comment on attachment 508701 [details] [diff] [review]
The fix

Do we want to display "0 matches found" or "No matches found"? If we want to display "0 matches found", we can skip noMatchesFound altogether, because PluralForm supports 0.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 508701 [details] [diff] [review]
The fix

clarkbw: do you want "0 matches found" or "No matches found". We currently have "No matches found" in the address book location, which is about the only other location I can find.

Comment 3

[Rimas Kudelis [use needinfo to ping]]

(In reply to comment #1)
> Do we want to display "0 matches found" or "No matches found"? If we want to
> display "0 matches found", we can skip noMatchesFound altogether, because
> PluralForm supports 0.

I think it would be nicer and more flexible if "No matches found" was a separate string. After all, everyone would still be free to translate it as "0 matches found"

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 508701 [details] [diff] [review]
The fix

I'd go with "No matches found", it's a little more natural human language.

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/5cd8b135a6ff