Closed Bug 630484 Opened 9 years ago Closed 9 years ago

Properly support plural forms in advance search dialog status message

Categories

(Thunderbird :: Search, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a3

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
I noticed a while back that the 1 match found/n matches found status message in the advanced search dialog doesn't properly support plural forms.

We should fix that, attaching a patch.
Attachment #508701 - Flags: review?(sid.bugzilla)
Comment on attachment 508701 [details] [diff] [review]
The fix

Do we want to display "0 matches found" or "No matches found"? If we want to display "0 matches found", we can skip noMatchesFound altogether, because PluralForm supports 0.
Attachment #508701 - Flags: review?(sid.bugzilla) → review+
Comment on attachment 508701 [details] [diff] [review]
The fix

clarkbw: do you want "0 matches found" or "No matches found". We currently have "No matches found" in the address book location, which is about the only other location I can find.
Attachment #508701 - Flags: ui-review?(clarkbw)
(In reply to comment #1)
> Do we want to display "0 matches found" or "No matches found"? If we want to
> display "0 matches found", we can skip noMatchesFound altogether, because
> PluralForm supports 0.

I think it would be nicer and more flexible if "No matches found" was a separate string. After all, everyone would still be free to translate it as "0 matches found"
Comment on attachment 508701 [details] [diff] [review]
The fix

I'd go with "No matches found", it's a little more natural human language.
Attachment #508701 - Flags: ui-review?(clarkbw) → ui-review+
Checked in: http://hg.mozilla.org/comm-central/rev/5cd8b135a6ff
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a3
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.