630561 - Rejected version being offered through automatic updates (doesn't install)

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect, P1)

Description

[Jorge Villalobos [:jorgev] (he/him)]

According to the developer of DNSSEC Validator (https://addons.mozilla.org/en-US/firefox/addon/64247), after getting a rejection for the latest version of his add-on (1.1.1), he was notified of an update. The update didn't work, fortunately, probably because of a missing file. The version was fully rejected, so its status is admin-disabled.

Comment 1

[Wil Clouser [:clouserw]]

Can he still reproduce the update offering?  If so, can you give me the URL that he's getting the offering on?

Comment 2

[Zbynek Michl]

The rejected version 1.1.1 is offered when user updates from older rejected version.

Here is it for 0.17.2alpha:

Datasource: Update Started
Datasource: Addon Update Started: [e-mail]
RDFItemUpdater:checkForUpdates sending a request to server for: https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=[e-mail]&version=0.17.2alpha&maxAppVersion=4.0b1&status=userDisabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=3.5.16&appOS=Linux&appABI=x86_64-gcc3&locale=cs-CZ&currentAppVersion=3.5.16, item = ({id:"[e-mail]", version:"0.17.2alpha", installLocationKey:"app-profile", minAppVersion:"3.0", maxAppVersion:"4.0b1", name:"DNSSEC Valid\xE1tor", xpiURL:"http://releases.mozilla.org/pub/mozilla.org/addons/64247/dnssec_validator-1.1.1-fx-linux.xpi", xpiHash:"sha256:de323c320d5f059580e1470401de610961f5e2dc9dd660e30d4aed9a56b76536", iconURL:"chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png", updateRDF:"", updateKey:"", type:2, targetAppID:"{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"})
RDFItemUpdater:onDatasourceLoaded: Found a newer version of this item:

({id:"[e-mail]", version:"1.1.1", installLocationKey:"app-profile", minAppVersion:"3.0", maxAppVersion:"4.0.*", name:"DNSSEC Valid\xE1tor", xpiURL:"http://releases.mozilla.org/pub/mozilla.org/addons/64247/dnssec_validator-1.1.1-fx-linux.xpi", xpiHash:"sha256:de323c320d5f059580e1470401de610961f5e2dc9dd660e30d4aed9a56b76536", iconURL:"", updateRDF:"", updateKey:"", type:2, targetAppID:"{ec8030f7-c20a-464f-9b0e-13a3a9e97384}"})
Datasource: Addon Update Ended: [e-mail], status: 1
Datasource: Update Ended

Comment 3

[Andy McKay]

Just notes on why its happening. The update is happening from 0.17.2alpha. That's on a beta version. Remora looks through the files on that version and picks the status up and then uses that to look for update files. All the 0.17.2alpha files are admin-disabled. That's probably not the desired result of the beta channel.

Comment 4

[Andy McKay]

Logic from jorgev. 

For an update on the beta channel:

- if the addon being updated from is STATUS_BETA or STATUS_PUBLIC, use that status

- if the addon being updated from is any other status, look for the latest in one of STATUS_LITE, STATUS_LITE_AND_NOMINATED, STATUS_PUBLIC

Comment 5

[Andy McKay]

r82078

Comment 7

[krupa raj[:krupa]]

verified