630568 - "Restore Previous Session" should ignore about:home

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Dave Garrett]

0) new profile in latest Minefield
1) close the "thanks for using the pre-release" tab
2) close Firefox
3) open Firefox again using the same profile
4) you'll get the about:home page and below the search field will be the new "Restore Previous Session" icon and text
5) click it and it will open another about:home window, which was the previous session

This is quite useless and potentially confusing. When about:home is all that was in the previous session it shouldn't offer to restore it here or from the history menu.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Not a dupe. Bug 627642 is about the act of restoring. This is about remembering session / determining if we should be able to restore the previous session.

Comment 4

[Dave Garrett]

Probably not a hard blocker, but might be a soft blocker (while those still last). Asking for at least status2.0:wanted+ because this is a rather obvious source of potential confusion. It could also make someone think there's dataloss when there's not, because it restores essentially an empty session.

Comment 5

[Dietrich Ayala (:dietrich)]

A little confusing and weird, but this doesn't block the release. Yeah, would take a safe fix if it makes the late train.

Comment 6

[eyal gruss]

after bug 627642 has landed, the restored session should open in the same window, which means no change in tabs. therefore i think this already minimizes the confusion potential.

Comment 7

[Dave Garrett]

Well, some source of confusion is reduced, but if you follow the STR in comment 0 exactly you'll now click the restore button and essentially nothing happens. This means that the new result is potentially a greater source of the confusion mentioned in comment 4: the user may think it's broken and they lost their previous session data because it didn't restore it.