630634 - After uninstalling restartless add-on, empty add-on bar reappears on next restart

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Drew Willcoxon :adw]

Spun out from bug 627484 comment 25.

1. New profile.
2. Install a restartless add-on (or maybe it has to be an SDK-built add-on that uses a widget).  The add-on bar should appear.
3. Uninstall the add-on.  The add-on bar should disappear.
4. Restart.

Actual results:
The empty add-on bar appears on restart.

Expected results:
The add-on bar should remain hidden on restart.

Comment 1

[Dietrich Ayala (:dietrich)]

Reproducible -> softblocker.

Comment 2

[Dietrich Ayala (:dietrich)]

Dave: my addon listener wasn't getting called when i uninstalled a restartless addon.

then i realized it *was* getting called... at shutdown.

then i realized that it was *actually* getting called whenever the AOM was closed.

shouldn't we be sending onUninstalling and onUninstalled when the uninstall happens? is this by design, or a bug?

Comment 3

[Dave Townsend [:mossop]]

Sort of by design, it's really a workaround for now to get the UI we wanted working in bug 553494. Basically when clicking uninstall we just disable the add-ons and don't uninstall them till the UI goes away.

Comment 4

[Dietrich Ayala (:dietrich)]

That's... problematic.

Comment 5

[Drew Willcoxon :adw]

Related to bug 620541, no?  If not, let's file a separate bug for the behavior described in comment 2.

Comment 6

[Dave Townsend [:mossop]]

Kind of a mix of that, bug 582002 and bug 612168

Comment 7

[Dietrich Ayala (:dietrich)]

Attachment: fix

handle enable/disable, which should've been done all along, but also works around the EM bug.

Comment 8

[Dietrich Ayala (:dietrich)]

http://hg.mozilla.org/mozilla-central/rev/afb62e95311a

Comment 9

[Dietrich Ayala (:dietrich)]

Oops, forgot to comment: Changed to hardblocker because the enable/disable support was absent, which is pretty broken.