630770 - "Assertion failure: !p.found(),"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

options('strict')
Function("function y(x,x)d")

asserts js debug shell on TM changeset 3b3710520c0e at Assertion failure: !p.found(), without -m nor -j.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This also occurs on Linux and is a frequent occurrence for fuzzers.

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   61758:4cb688939afc
user:        Jeff Walden
date:        Wed Jan 26 16:46:38 2011 -0800
summary:     Bug 629187 - Strict mode keywords are accepted as argument names and function name for strict mode functions.  r=jimb

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Patch and half-test

The test is a lie, kind of.  There's no way to check that the warning happened, and that it happened only once, without hacking at the shell error reporter, and I'm not interested in spending time to do that now.  This works as a don't-assert test, I'm moving on.

Comment 3

[Jim Blandy :jimb]

Comment on attachment 509040 [details] [diff] [review]
Patch and half-test

The test should have a comment explaining that it's trying to provoke an assertion. r=me with that.

Comment 4

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/e518c56eaffd

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/e518c56eaffd

Comment 6

[Christian Holler (:decoder)]

Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929