630840 - nsIStandaloneNativeMenu.menuWillOpen doesn't handle menu flashing for keyboards shortcuts

Status: NEW

(Core :: Widget: Cocoa, defect)

Description

[Asaf Romano (gone)]

While trying to workaround bug 630826, I tackled what's now called bug 630830. While trying to workaround bug 630830, I tackled what's now called bug 630839. I figured nsIStandaloneNativeMenu.menuWillOpen could help. Well, I figured it wrong.  While it does fire onpopupshowing etc., the file menu still flash for removed menu items.

I suppose fixing bug 630839 cannot happen in time for Fx4, but this one should be easy, I hope. Anyway, one of this bugs must be fixed for bug 
580638 solution to work right on mac. Nominating.

Comment 1

[Asaf Romano (gone)]

CCing Josh.

Comment 2

[Tom Dyas]

nsIStandaloneNativeMenu is only used for the Dock menu support.  It provides a way to instantiate a nsMenuX object without it being part of the objects used to model the menu bar.  There is no way currently to obtain a nsIStandaloneNativeMenu for anything in the regular menu bar (nor should there be any need).

Comment 3

[Asaf Romano (gone)]

Oddly enough it did work! (I do get popupwhowing dispatch for the file menu, for example).

Comment 4

[Tom Dyas]

nsStandaloneNativeMenu::MenuWillOpen uses a helper function to simulate the opening and closing of menus.  The helper (UpdateMenu) calls MenuOpened() and MenuClosed on the nsMenuX object held by the nsStandaloneNativeMenu.  Those two methods cause the firing of the popupshowing dispatch.  Not sure why it would dispatch for the file menu though. See widget/src/cocoa/nsStandaloneNativeMenu.mm lines 93-106.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Don't think this blocks.