630898 - Inconsistent definition of js/JS_CurrentThreadId

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Apparently, we still do js shell builds with JS_THREADSAFE off. I notice that the relevant portions of jslock.h are:

#ifdef JS_THREADSAFE
#define js_CurrentThreadId()        PR_GetCurrentThread()
#else
#define JS_CurrentThreadId() 0
#endif

Why the discrepancy? It means sprinkling #ifdefs in the code that uses *_CurrentThreadId().

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Define both js_ and JS_CurrentThreadId with or without JS_THREADSAFE

Here's a sample patch that applies to tracemonkey after jorendorff's fix from bug 626743. It just defines both.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 509140 [details] [diff] [review]
Define both js_ and JS_CurrentThreadId with or without JS_THREADSAFE

We should not have JS_CurrentThreadId -- looks like a typo/thinko/capitalize-o.

Just js_CurrentThreadId. No way is this public API. JS_ALL_CAPS_MACROs aside, js_ for old C-compatible private and friend APIs.

/be

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: s/JS_CurrentThreadId/js_CurrentThreadId/

Comment 4

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/tracemonkey/rev/e5866bf9c573

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/e5866bf9c573