Closed Bug 631300 Opened 9 years ago Closed 9 years ago

Firefox Sync should synchronize "do not track" pref

Categories

(Cloud Services :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Just noticed that I'd enabled "do not track" in my Firefox profile on one machine, but that change didn't propagate to the rest of my Sync'ed machines.

This seems like the type of pref that makes a lot of sense to synchronize via sync, since a user who proactively takes the step to request not being tracked will presumably not want to be tracked on *any* of their machines.

(Sid: I assume you agree, but correct me if I'm off base here.)

Can we add this to the list of sync'd prefs?  AIUI, the pref to sync here would be:
  privacy.donottrackheader.enabled
so I think this just involves creating a bool pref named 
  services.sync.prefs.sync.privacy.donottrackheader.enabled
(right?)
> (Sid: I assume you agree, but correct me if I'm off base here.)

Yes, sync it.
(In reply to comment #0)
> Can we add this to the list of sync'd prefs?  AIUI, the pref to sync here would
> be:
>   privacy.donottrackheader.enabled
> so I think this just involves creating a bool pref named 
>   services.sync.prefs.sync.privacy.donottrackheader.enabled
> (right?)

Correct. The services.sync.prefs.sync.* pref would also have to be set to true. It should live in browser/app/profile/firefox.js.
Attached patch fixSplinter Review
fix as described. I expect it should work -- haven't tested yet, but I'm about to.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #509498 - Flags: review?(philipp)
Attachment #509498 - Flags: review?(philipp) → review+
Comment on attachment 509498 [details] [diff] [review]
fix

Confirmed that this works in a build w/ this patch.

(successfully synchronized the enabled donottrack pref from profile A to profile B; then I disabled the pref in profile B and resync'd, and confirmed that the pref became disabled in profile A on its next sync.)

Requesting approval to land.
Attachment #509498 - Flags: approval2.0?
Depends on: DNT
Attachment #509498 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/313e35cc080e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified in beta12 against stage-auth
Status: RESOLVED → VERIFIED
Duplicate of this bug: 652631
You need to log in before you can comment on or make changes to this bug.