631448 - Try TBPL should link to build directory

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, enhancement)

Description

[Jesse Ruderman]

It would be nice if I get from TBPL to downloadable builds easily.

For Try, the URLs can be constructed from the pusher and rev:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-920fe6f57d17/

For non-Try, it might be harder, because the URLs are like:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx-debug/1296793077/

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

This is adding a link to the build directory just before short/long log links.
The build is only shown if you click on a build. Not that we can't show it every time but I assume you might not be interested by it if you click on a test job.

This patch handles thunderbird try server too ;)

Comment 2

[Arpad Borsos [:Swatinem]]

Comment on attachment 512158 [details] [diff] [review]
Patch v1

I hope you have checked if there is enough space for the link? (I didn’t)

>+            var dir = "firefox";
>+            if (repo == 'try-comm-central') {
>+              dir = "thunderbird";
>+            }

I like the ? : syntax more, but its fine either way.

>+            return '<a href="https://ftp.mozilla.org/pub/mozilla.org/' +
>+                   dir + '/tryserver-builds/' + result.push.pusher + '-' +
>+                   result.revs[repo] + '/">go to build directory</a>';

Never knew this was available using https, guess I learn new things all the time :-)

Comment 3

[Mounir Lamouri (:mounir)]

Pushed:
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/574b51478ded