631502 - Use a filter for pressed icon state in preferences windows

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

Instead of having all icons twice in chrome://browser/skin/preferences/Options.png , we can just use a filter for the darkening of the icons that happens when they're pressed.

This patch removes the lower row of Options.png and the associated :active:hover styles and instead sets a filter in the toolkit preferences stylesheet. That means extensions benefit, too, and we also don't need a new image for the pressed state of the Sync button (see bug 583342).

Comment 1

[Dão Gottwald [:dao]]

(In reply to comment #0)
> This patch removes the lower row of Options.png and the associated
> :active:hover styles

Would you mind doing this for winstripe too?

Comment 2

[Markus Stange [:mstange]]

Huh, sure. Why does winstripe even have two rows?

Comment 3

[Markus Stange [:mstange]]

Attachment: v2

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 509733 [details] [diff] [review]
v2

>+++ b/toolkit/themes/pinstripe/global/filters.svg
>@@ -0,0 +1,10 @@
>+<svg xmlns="http://www.w3.org/2000/svg">
>+  <filter id="pressedFilter" color-interpolation-filters="sRGB">

How about id="iconPressed"? "Filter" seems redundant.

Comment 5

[Markus Stange [:mstange]]

Attachment: v3

Done.

Requesting approval2.0: Code simplification + theme polish, low risk.

Comment 6

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/cd6e4e724118