631539 - "Tagging started" and "All signed builds available" emails should be sent to release-drivers mailing list

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Rail Aliiev [:rail]]

Attachment: Add PassRecipients

For both cases we use ChangeNotifier.

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 509768 [details] [diff] [review]
Add PassRecipients

http://hg.mozilla.org/build/buildbotcustom/rev/6f0b68d937ac

Comment 3

[Armen [:armenzg]]

I didn't see a "tagging started" email after I triggered 3.6.14 build2.

http://hg.mozilla.org/build/buildbotcustom/rev/09e7dbe6c7b1

Comment 4

[Rail Aliiev [:rail]]

(In reply to comment #3)
> I didn't see a "tagging started" email after I triggered 3.6.14 build2.

Hmmm, it worked fine in staging. Maybe ChangeNotifier isn't reconfig safe? Let's see how it will work next time after a downtime and a full master restart.

Comment 5

[Rail Aliiev [:rail]]

Attachment: Separate pass/all recipients

Looks like (and iirc) we should send emails to the Mailman list as a separate message.

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 513759 [details] [diff] [review]
Separate pass/all recipients

Do we know why we need to send a separate message to mailman?

Comment 7

[Chris AtLee [:catlee]]

(In reply to comment #6)
> Comment on attachment 513759 [details] [diff] [review]
> Separate pass/all recipients
> 
> Do we know why we need to send a separate message to mailman?

A comment in the patch to explain this would be good too.

Comment 8

[Rail Aliiev [:rail]]

Attachment: Separate pass/all recipients

* Added comments
* used for loop to avoid boilerplate
* tested in staging + test mailman list

Comment 9

[Chris AtLee [:catlee]]

Comment on attachment 513786 [details] [diff] [review]
Separate pass/all recipients

I think we should loop over all entries of AllRecipients + PassRecipients, since they could contain more than one item each.

Comment 10

[Rail Aliiev [:rail]]

Attachment: Separate pass/all recipients

(In reply to comment #9)
> I think we should loop over all entries of AllRecipients + PassRecipients,
> since they could contain more than one item each.

Sure. Also note, that extraRecipients have to be a tuple or list.

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 513800 [details] [diff] [review]
Separate pass/all recipients

http://hg.mozilla.org/build/buildbotcustom/rev/af43662c937f