Panorama uses the wrong font on Mac

VERIFIED FIXED

Status

VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: pcwalton, Assigned: pcwalton)

Tracking

({polish})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Assignee)

Description

8 years ago
On the Mac, Panorama uses Tahoma instead of Lucida Grande, the UI font.
(Assignee)

Updated

8 years ago
Keywords: polish
(Assignee)

Comment 1

8 years ago
Posted patch Proposed patch. (obsolete) — Splinter Review
Proposed patch attached.
Attachment #509831 - Flags: review?(ian)

Updated

8 years ago
Depends on: 630777
I believe just font: message-box; should work here.
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> I believe just font: message-box; should work here.

It doesn't work, because Panorama changes the font size manually, which overrides that font declaration. We need to set only the font family.
This works just fine over here:

data:text/html,<body style="font: message-box; font-size: 20px">Test
(Assignee)

Comment 5

8 years ago
Posted patch Proposed patch, version 2. (obsolete) — Splinter Review
Oh, huh, if you leave the font-size in it works. Thanks for the tip. Here's a new patch that fixes Windows as well (bug 630777).
Attachment #509831 - Attachment is obsolete: true
Attachment #509875 - Flags: review?(ian)
Attachment #509831 - Flags: review?(ian)
What's the !importing supposed to override?
(Assignee)

Comment 7

8 years ago
Posted patch Proposed patch, version 3. (obsolete) — Splinter Review
Dunno, but removing it seems to work. New patch attached.
Attachment #509875 - Attachment is obsolete: true
Attachment #509876 - Flags: review?(ian)
Attachment #509875 - Flags: review?(ian)
Comment on attachment 509876 [details] [diff] [review]
Proposed patch, version 3.

Please remove the !important in gnomestripe as well.
Attachment #509876 - Flags: review?(ian) → review+
(Assignee)

Comment 9

8 years ago
Posted patch Proposed patch, version 4. (obsolete) — Splinter Review
Patch version 4 attached. Requesting approval; this is a very low-risk three-line CSS change that changes the font of the tabs.
Attachment #509876 - Attachment is obsolete: true
Attachment #509880 - Flags: approval2.0?
Comment on attachment 509880 [details] [diff] [review]
Proposed patch, version 4.

Why "font" on linux and mac but "font-family" on windows?
Blocks: 630777
No longer depends on: 630777
(Assignee)

Comment 11

8 years ago
Ouch, leave it to me to screw that up. New version of the patch attached.
Attachment #509880 - Attachment is obsolete: true
Attachment #509889 - Flags: approval2.0?
Attachment #509880 - Flags: approval2.0?
Blocks: 627096
Comment on attachment 509889 [details] [diff] [review]
Proposed patch, version 5.

This should have ui-review before asking for approval.
Attachment #509889 - Flags: approval2.0?
(Assignee)

Updated

8 years ago
Attachment #509889 - Flags: ui-review?(faaborg)
(Assignee)

Comment 13

8 years ago
Posted image Screenshot.
Screenshot attached.
Attachment #509889 - Flags: ui-review?(faaborg) → ui-review+
(Assignee)

Comment 14

8 years ago
Comment on attachment 509889 [details] [diff] [review]
Proposed patch, version 5.

Approval requested again!
Attachment #509889 - Flags: approval2.0?
Attachment #509889 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 15

8 years ago
http://hg.mozilla.org/mozilla-central/rev/791cca7bf97b
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 16

8 years ago
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110215 Firefox/4.0b12pre

Verified issue and it's no longer present.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.