631662 - We are painting thumbnails while in the background

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Ian Gilman [:iangilman]]

We receive the events when the user is not in the Panorama UI, but we're supposed to just queue them up for later handling; it's not till you reenter the Panorama UI that thumbnails are supposed to be actually updated. 

bug 625561 has evidence that we're actually updating thumbnails while not in the Panorama UI. Looking at the code, we don't have an explicit check for whether you're in TabView; we just rely on paintingPaused, which should be set to true when TabView is hidden, but maybe it's not?

This needs to be fixed due to its perf impact on regular pages.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Confirming. We're even painting twice when switching tabs.

Comment 2

[Johnathan Nightingale [:johnath]]

Hardblocker - panorama should not impact perf for people who never use it. Can we get a patch up here right away?

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Yep, it's almost done.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #2)
> Hardblocker - panorama should not impact perf for people who never use it. Can
> we get a patch up here right away?

Oh and to be clear: this is not affecting users that never opened panorama.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 6

[Ian Gilman [:iangilman]]

Comment on attachment 509933 [details] [diff] [review]
patch v1

Beautiful

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #5)
> Created attachment 509933 [details] [diff] [review]
> patch v1

Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]&rev=0cc58f595787

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 9

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/378f8ebcc920