We are painting thumbnails while in the background

RESOLVED FIXED in Firefox 4.0b12

Status

defect
P2
normal
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: iangilman, Assigned: ttaubert)

Tracking

Trunk
Firefox 4.0b12

Firefox Tracking Flags

(blocking2.0 final+)

Details

(Whiteboard: [hardblocker][has patch][qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
We receive the events when the user is not in the Panorama UI, but we're supposed to just queue them up for later handling; it's not till you reenter the Panorama UI that thumbnails are supposed to be actually updated. 

bug 625561 has evidence that we're actually updating thumbnails while not in the Panorama UI. Looking at the code, we don't have an explicit check for whether you're in TabView; we just rely on paintingPaused, which should be set to true when TabView is hidden, but maybe it's not?

This needs to be fixed due to its perf impact on regular pages.
blocking2.0: --- → ?
Confirming. We're even painting twice when switching tabs.
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Version: unspecified → Trunk
(Assignee)

Updated

8 years ago
Summary: Are we painting thumbnails while in the background? → We are painting thumbnails while in the background
Hardblocker - panorama should not impact perf for people who never use it. Can we get a patch up here right away?
blocking2.0: ? → final+
Whiteboard: [hardblocker]
Yep, it's almost done.
(In reply to comment #2)
> Hardblocker - panorama should not impact perf for people who never use it. Can
> we get a patch up here right away?

Oh and to be clear: this is not affecting users that never opened panorama.
Posted patch patch v1 (obsolete) — Splinter Review
Attachment #509933 - Flags: review?(ian)
(Reporter)

Comment 6

8 years ago
Comment on attachment 509933 [details] [diff] [review]
patch v1

Beautiful
Attachment #509933 - Flags: review?(ian) → review+
Attachment #509933 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed

Updated

8 years ago
Whiteboard: [hardblocker] → [hardblocker][has patch]
http://hg.mozilla.org/mozilla-central/rev/378f8ebcc920
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
Whiteboard: [hardblocker][has patch] → [hardblocker][has patch][qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.