631759 - throttle, signature regexes should be configurable via web UI

Status: RESOLVED DUPLICATE of bug 528390

(Socorro :: Infra, task)

Description

[Robert Helmer [:rhelmer]]

We've done full releases to change these settings lately, because they are actual python code so don't fit cleanly into our config override system which is based on environment variables. Doing full releases for these sorts of changes seems a little heavy, and could accidentally introduce undesired changes.

Since these may need to be changed on short notice, and these settings are interesting to mozilla developers and release drivers, perhaps they should be in the web admin interface instead?

It seems important to track the history of these changes, and also to try them on staging first, so perhaps they could be read-only to most users, and read-write to Socorro admins, and Socorro could store the historical settings.

Alternatively, I'd like to make these fit more cleanly into our config override system.

Comment 1

[(not currently active) Ted Mielczarek]

I filed bug 588538 some time ago for making the signature generation bits editable via the web interface.

Comment 2

[Robert Kaiser]

Bug 565412 is already on file for the regexes, right? Not sure if the throttle in the UI is the same or something different, but I'd hope that throttling will die anyhow... ;-)

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to comment #2)
> Bug 565412 is already on file for the regexes, right? Not sure if the throttle
> in the UI is the same or something different, but I'd hope that throttling will
> die anyhow... ;-)

There are two places where a form of throttling is set:
1) collector config (decides whether this crash will be processed)
2) "branch data" admin UI (alters the ADU graph)

Also, there are a few regexes for generating and filtering different signatures, in the processor config. 

The primary reason I filed this bug is that we need to check in, tag, restarting Socorro services, etc. to push config changes like the collector throttle config and the processor regexes.

We are able to override most Socorro config settings via environment variables, but these two are more complex Python objects and not simple strings so it's not as trivial to override, which is what I meant by:

(In reply to comment #0)
> Alternatively, I'd like to make these fit more cleanly into our config override
> system.

Basically I'd like to simplify the way these are configured, and make them available to developers to manipulate more directly without requiring pushing changes and restarting Socorro services.

If there are bugs on file that are already addressing it we should dupe them there, but I am not really clear how bug 565412 fits in?

Bug 528390 (which Ted's bug from comment 1 was duped to) looks like a good enough fit. I am more interested in getting the signature regexes directly configurable than the throttle settings TBH.

Comment 4

[Robert Kaiser]

Gah, I was misled by the summary and by not finding bug 528390 in my list, which was the one I actually meant, sorry.
Bug 537853 and bug 598734 also seem related, btw.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

What about vcsMappings?  They're not as common as the signature or throttle changes, certainly, but they also seem like they're an item that should be "configurable" by admins instead of requiring a full Socorro release, a special patch to be generated, or waiting two months for someone to (have yet to have taken) care of it (e.g., bug 623471).

Comment 6

[Robert Kaiser]

(In reply to Robert Helmer [:rhelmer] from comment #3)
> Bug 528390 (which Ted's bug from comment 1 was duped to) looks like a good
> enough fit. I am more interested in getting the signature regexes directly
> configurable than the throttle settings TBH.

Duping to that in the light of that comment. If that bug is ever resolved and doesn't take us as far as we like, we'll at least have UI in place that we can then file bugs on to extend it.