Closed
Bug 631868
Opened 15 years ago
Closed 15 years ago
Tab drift in TabItem_setBounds code
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 4.0b12
People
(Reporter: mitcho, Assigned: mitcho)
References
Details
(Whiteboard: [cleanup][qa-])
Attachments
(1 file, 1 obsolete file)
|
6.39 KB,
patch
|
Details | Diff | Splinter Review |
Tabbing in the TabItem_setBounds code on trunk is wacked out... a section of it just got overly indented. Fix it.
|
Assignee | |
Comment 1•15 years ago
|
||
|
||
Comment 2•15 years ago
|
||
Mitcho, thanks for catching this!
Presumably the "ignore white space changes" version of the patch for bug 624931 landed, causing this.
|
|
||
Updated•15 years ago
|
Attachment #510152 -
Flags: review?(ian) → review+
|
|
||
Comment 3•15 years ago
|
||
(In reply to comment #0)
> Tabbing in the TabItem_setBounds code on trunk is wacked out... a section of it
> just got overly indented. Fix it.
Possibly the wrong version of the patch got checked in. Anyway, thanks for the patch :)
|
|
Assignee | |
Comment 4•15 years ago
|
||
Comment on attachment 510152 [details] [diff] [review]
Trivial patch
Trivial code cleanup bug. No risk! Approval please.
Attachment #510152 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #510152 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #510152 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Comment 6•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
|
||
Updated•10 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•