631956 - Intermittent browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected example.org and | sessionstore got correct userTypedClear - Got undefined, expected 0

Reporter

Description

•

15 years ago

A continuation of bug 597634: http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1297045535.1297047178.3637.gz Rev3 WINNT 6.1 tracemonkey opt test mochitest-other on 2011/02/06 18:25:35 s: talos-r3-w7-049 TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_522545.js | userTypedClear was not changed when changing gURLBar.value TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected example.org TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_522545.js | sessionstore got correct userTypedClear - Got undefined, expected 0 Happened on a merge from mozilla-central, so we can't even blame some patch on TM for breaking it.

Comment hidden (Legacy TBPL/Treeherder Robot)

Robert Strong (they/them - no direct email)

Comment 228

•

14 years ago

https://tbpl.mozilla.org/php/getParsedLog.php?id=7781494&tree=Mozilla-Aurora

Comment hidden (Legacy TBPL/Treeherder Robot)

ryanvm%gmail.com https://tbpl.mozilla.org/php/getParsedLog.php?id=10488004&tree=Mozilla-Inbound Rev3 WINNT 5.1 mozilla-inbound debug test mochitest-other on 2012-03-29 16:03:54 17390 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.control 17391 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.label 17392 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.value 17393 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.image 17394 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.priority 17395 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.type TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 332 bytes during test execution TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of CondVar with size 16 bytes TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of Mutex with size 12 bytes TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of nsCacheEntryHashTable with size 36 bytes TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of nsCacheService with size 148 bytes TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of nsDiskCacheBinding with size 52 bytes TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected example.org TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | sessionstore got correct userTypedClear - Got undefined, expected 0

Comment hidden (Legacy TBPL/Treeherder Robot)

philor https://tbpl.mozilla.org/php/getParsedLog.php?id=10610666&tree=Mozilla-Inbound Rev3 WINNT 5.1 mozilla-inbound debug test mochitest-other on 2012-04-03 13:53:00 17404 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.control 17405 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.label 17406 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.value 17407 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.image 17408 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.priority 17409 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xul | append notification.type TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected example.org TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | sessionstore got correct userTypedClear - Got undefined, expected 0 TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 332 bytes during test execution TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of CondVar with size 16 bytes TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of Mutex with size 12 bytes TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of nsCacheEntryHashTable with size 36 bytes TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of nsCacheService with size 148 bytes TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of nsDiskCacheBinding with size 52 bytes

Comment hidden (Legacy TBPL/Treeherder Robot)

Tim Taubert [:ttaubert] (inactive)

Assignee

Comment 456

•

13 years ago

https://tbpl.mozilla.org/php/getParsedLog.php?id=10780135&tree=Fx-Team

Comment hidden (Legacy TBPL/Treeherder Robot)

ryanvm%gmail.com https://tbpl.mozilla.org/php/getParsedLog.php?id=13334906&tree=Mozilla-Inbound Rev3 WINNT 5.1 mozilla-inbound debug test mochitest-other on 2012-07-08 12:14:50 slave: talos-r3-xp-046 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected example.org TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | sessionstore got correct userTypedClear - Got undefined, expected 0 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug602432.js | Stacked group item update (1341777346548) > first item (1341777346902) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug602432.js | Stacked group item update (1341777346554) > first item (1341777346902) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug602432.js | Stacked group item update (1341777346559) > first item (1341777346902) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug602432.js | Stacked group item update (1341777346564) > first item (1341777346902) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug602432.js | Stacked group item update (1341777346569) > first item (1341777346902) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug602432.js | Stacked group item update (1341777346574) > first item (1341777346902) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug602432.js | Stacked group item update (1341777346599) > first item (1341777346902) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug602432.js | Stacked group item update (1341777346601) > first item (1341777346902) TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug602432.js | Stacked group item update (1341777346603) > first item (1341777346902)

Comment hidden (Legacy TBPL/Treeherder Robot)

Nathan Froyd [:froydnj]

Comment 656

•

13 years ago

FWIW, I can perma-orange this bug with the patches in bug 715376, if anybody really wanted to take a look. I'm poking at this today, but I have very little idea about how all the pieces fit together.

Tim Taubert [:ttaubert] (inactive)

Assignee

Comment 657

•

13 years ago

Attached patch patch v1 — Details — Splinter Review

To prepare for the sub-test that covers userTypedValue, we call setBrowserState() and pass an empty session to it. That means we're actually restoring a session. While the single blank tab is still loading, _collectTabData() still returns the tab's restore data because it's not fully restored, yet. Thus we need to wait for it to load until we can compare the value returned by getBrowserState() to the expected values. We need to keep the executeSoon() here so that the test doesn't fail because we rely on a specific order of registered event handlers.

Assignee: nobody → ttaubert

Status: NEW → ASSIGNED

Attachment #645831 - Flags: review?(gavin.sharp)

:Gavin Sharp [email: gavin@gavinsharp.com]

Updated

•

13 years ago

Attachment #645831 - Flags: review?(gavin.sharp) → review?(nfroyd)

Comment hidden (Legacy TBPL/Treeherder Robot)

Nathan Froyd [:froydnj]

Comment 660

•

13 years ago

Comment on attachment 645831 [details] [diff] [review] patch v1 Review of attachment 645831 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for looking at this!

Attachment #645831 - Flags: review?(nfroyd) → review+

Tim Taubert [:ttaubert] (inactive)

Assignee

Comment 661

•

13 years ago

https://hg.mozilla.org/integration/fx-team/rev/cc2c4ae4886f

Whiteboard: [orange] → [orange][fixed-in-fx-team]

Comment hidden (Legacy TBPL/Treeherder Robot)

Tim Taubert [:ttaubert] (inactive)

Assignee

Comment 666

•

13 years ago

https://hg.mozilla.org/mozilla-central/rev/cc2c4ae4886f

Status: ASSIGNED → RESOLVED

Closed: 13 years ago

Resolution: --- → FIXED

Whiteboard: [orange][fixed-in-fx-team] → [orange]

Target Milestone: --- → Firefox 17

Comment hidden (Legacy TBPL/Treeherder Robot)

Nobody; OK to take it and work on it

Updated

•

13 years ago

Keywords: intermittent-failure

Nobody; OK to take it and work on it

Updated

•

13 years ago

Whiteboard: [orange]