632434 - [bn-BD] review comments on sign-off for Bengali (Bengladesh)

Status: RESOLVED FIXED

(Mozilla Localizations :: bn-BD / Bengali, defect)

Description

[Axel Hecht [:Pike]]

Jamil, I found a few things we should fix for release, on top of the search stuff in bug 603945.

http://hg.mozilla.org/l10n-central/bn-BD/diff/efb588a5a67e/browser/chrome/browser/pageInfo.dtd has numbers transcribed, those are actually XML width and height attribute values, and need to be in latin script. (Yeah, arabic numbers, history not helping.)

http://hg.mozilla.org/l10n-central/bn-BD/diff/efb588a5a67e/toolkit/chrome/global/headsUpDisplay.properties#l1.71 ff has the () for the js method calls separated from the actual method names, that should probably be "console.error() কল লগ" or so.

http://hg.mozilla.org/l10n-central/bn-BD/diff/efb588a5a67e/toolkit/chrome/global/intl.properties translated numbers and font groups, those should be undone. Also the "true" is either "true" or "false" for intl.menuitems.insertseparatorbeforeaccesskeys, not the translation thereof.

http://hg.mozilla.org/l10n-central/bn-BD/diff/efb588a5a67e/toolkit/chrome/mozapps/downloads/downloads.dtd#l1.7 transcribed numbers.

http://hg.mozilla.org/l10n-central/bn-BD/diff/efb588a5a67e/toolkit/chrome/mozapps/extensions/blocklist.dtd#l1.5 translated a CSS spec.

http://hg.mozilla.org/l10n-central/bn-BD/diff/efb588a5a67e/toolkit/chrome/mozapps/extensions/extensions.dtd#l1.359, too.

http://hg.mozilla.org/l10n-central/bn-BD/diff/efb588a5a67e/toolkit/chrome/mozapps/handling/handling.dtd

These should be easy to fix, and they're just too many. Despite the fact that I'd love to take that sign-off for all the good pieces, the broken numbers probably impact the UI too widely.

I assume the number stuff is coming from a tool that you use? Does that have a pref to not translate numbers? You should really use that. Or file a bug to add such a pref ;-)

Comment 1

[Jamil Ahmed]

Axel, thanks for pointing those out. Currently we are reviewing all files, but can you please help us with some tips, how to check this easily. :)

Comment 2

[Axel Hecht [:Pike]]

Well, it wasn't easy when I checked, I went through the complete diff.

You could grep for your numbers to make things somewhat easier. Here's my naive approach, just searching for 2 and 0. You may want to put in all numbers:

find * -type f|xargs egrep '[২০]'

That finds a bunch that are totally fine, I guess, but

browser/chrome/browser/pageInfo.dtd:<!ENTITY pageInfoWindow.width "৬০০">
browser/chrome/browser/pageInfo.dtd:<!ENTITY pageInfoWindow.height "৭০০">

should be latin1 numbers, too.

"This string should be untranslated" like the one in intl.properties, that's really awkward, and I only know one or two myself, by experience. There should be more, though.

Comment 3

[Jamil Ahmed]

Thanks a lot! I am working on it.

Comment 4

[Jamil Ahmed]

Can you please check my latest update? :)
http://hg.mozilla.org/l10n-central/bn-BD/file/22d9890bf65c

Comment 5

[Axel Hecht [:Pike]]

That's looking much better, I took that.

I found one "not()" to be translated in xslt.properties, so I've set up an mxr search that you can go through for things that may very well be DOM method calls, http://mxr.mozilla.org/mozilla-central/search?string=%28%29&find=locales/en-US/. Didn't cross check those in bn-BD, but that looks like a good thing to do.

Also, http://mxr.mozilla.org/mozilla-central/search?string=[0-9][0-9]em&regexp=1&find=locales%2Fen-US%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central is a pretty good list of size specs where you don't want to translate the css keywords.

Marking FIXED, as the original issue is resolved, you can follow up on the other hints on the side. Thanks.

Comment 6

[Jamil Ahmed]

Thanks again! :)