632462 - enforce character limit on tags

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Pratibha]

-adding a lengthy tag containing more than 255 chars results in:
HTTP/1.1 500 INTERNAL SERVER ERROR 
Server: Apache 
Vary: X-Mobile, Accept-Encoding 
X-Backend-Server: pm-app-amo24 
Cache-Control: no-cache 
Content-Type: text/html; charset=utf-8 
Content-Encoding: gzip 
Date: Tue, 08 Feb 2011 17:40:38 GMT 
X-Content-Security-Policy-Report-Only: policy-uri /services/csp/policy 
Via: Moz-Cache-pm-zlb-amo01 
Connection: close 
Set-Cookie: multidb_pin_writes=y; expires=Tue, 08-Feb-2011 17:40:59 GMT; Max-Age=15; Path=/ 
X-Frame-Options: DENY 

As tags have minimum limit of 2 characters,similarly an upper limit is expected

Comment 1

[Pratibha]

noticed while testing on AMO next server
https://addons-next.allizom.org/en-US/developers/addon/click-1/edit_basic/edit

Comment 2

[krupa raj[:krupa]]

 File "/data/amo_python/www/next/zamboni/vendor/src/django/django/core/handlers/base.py", line 109, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/next/zamboni/apps/amo/decorators.py", line 75, in wrapper
   return f(*args, **kw)

 File "/data/amo_python/www/next/zamboni/apps/amo/decorators.py", line 67, in wrapper
   return f(*args, **kw)

 File "/data/amo_python/www/next/zamboni/apps/addons/decorators.py", line 22, in wrapper
   return f(request, addon, *args, **kw)

 File "/data/amo_python/www/next/zamboni/apps/amo/decorators.py", line 22, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/next/zamboni/apps/devhub/views.py", line 69, in wrapper
   return fun()

 File "/data/amo_python/www/next/zamboni/apps/devhub/views.py", line 62, in <lambda>
   **kw)

 File "/data/amo_python/www/next/zamboni/apps/devhub/views.py", line 615, in addons_section
   addon = form.save(addon)

 File "/data/amo_python/www/next/zamboni/apps/addons/forms.py", line 73, in save
   Tag(tag_text=t).save_tag(addon)

 File "/data/amo_python/www/next/zamboni/apps/tags/models.py", line 50, in save_tag
   tag, created = Tag.objects.get_or_create(tag_text=self.tag_text)

 File "/data/amo_python/www/next/zamboni/vendor/src/django/django/db/models/manager.py", line 135, in get_or_create
   return self.get_query_set().get_or_create(**kwargs)

 File "/data/amo_python/www/next/zamboni/vendor/src/django/django/db/models/query.py", line 382, in get_or_create
   raise e

IntegrityError: (1062, "Duplicate entry 'firefox111firefox111firefox111firefox111firefox111firefox111fire' for key 2")

Comment 3

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/b1e598b322548d6263a325dc2c7fbc46b185c4be

Comment 4

[Pratibha]

Attachment: tagname can be upto 128 character limit

Comment 5

[Pratibha]

Verified at:
https://addons-next.allizom.org/en-US/developers/addon/click-1233/edit

Maximum limit is set to 128 chars for a tag name.
Adding a tag with more than 128 chars now shows up an error message as "All tags must be 128 characters or less after invalid characters are removed."