Closed Bug 632595 Opened 13 years ago Closed 13 years ago

Update public suffix list for changes in .eg and .uk

Categories

(Core Graveyard :: Networking: Domain Lists, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(status2.0 .x-fixed, status1.9.2 .18-fixed, status1.9.1 .20-fixed)

RESOLVED FIXED
Tracking Status
status2.0 --- .x-fixed
status1.9.2 --- .18-fixed
status1.9.1 --- .20-fixed

People

(Reporter: pkasting, Assigned: gerv)

Details

(Keywords: verified1.9.2)

Attachments

(1 file)

Recently two Chromium bugs ( http://crbug.com/71638 and http://crbug.com/72360 ) have pointed out websites that run afoul of the current public suffix rules: police.uk and enc.eg, respectively.

Looks like we need to take a look at these registrars' current policies and update.
Attached patch Patch v.1Splinter Review
I checked a few sources and can't find any more omissions from the .uk list apart from police.uk. The .eg stuff is straight from Wikipedia.

Gerv
Assignee: nobody → gerv
Status: NEW → ASSIGNED
Attachment #519395 - Flags: review?(pkasting)
Comment on attachment 519395 [details] [diff] [review]
Patch v.1

I'm sorry, this slipped through my radar somehow!
Attachment #519395 - Flags: review?(pkasting) → review+
http://hg.mozilla.org/mozilla-central/rev/5b7a081209bd

Gerv
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Backed out due to xpcshell failure on all platforms.
See: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1305900628.1305901763.25019.gz&fulltext=1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The cause of the failure was this bug; the new TLDs for .pk contain what Firefox things is a non-permitted codepoint (200E). And the Verisign IDN checker agrees:
http://mct.verisign-grs.com/conversiontool/convertServlet?input=%E2%80%8E%E2%80%8E%D9%BE%D8%A7%D9%83%D8%B3%D8%AA%D8%A7%D9%86&type=UTF8

I will check this all back in without that change, and we can open another bug to fix the problem.

Gerv
Sorry, comment 5 was in the wrong bug (see bug 658084).

Gerv
Attempt 2: http://hg.mozilla.org/mozilla-central/rev/a2affb2e653f

Gerv
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Attachment #519395 - Flags: approval2.0?
Attachment #519395 - Flags: approval1.9.2.18?
Attachment #519395 - Flags: approval1.9.1.20?
Comment on attachment 519395 [details] [diff] [review]
Patch v.1

Approved for 1.9.2.18 and 1.9.1.20, a=dveditz for release-drivers
Approved for the mozilla2.0 repository, a=dveditz for release-drivers

Mozilla only has plans to build 1.9.2 releases, but you're approved to land on the other two repos if you'd like.
Attachment #519395 - Flags: approval2.0?
Attachment #519395 - Flags: approval2.0+
Attachment #519395 - Flags: approval1.9.2.18?
Attachment #519395 - Flags: approval1.9.2.18+
Attachment #519395 - Flags: approval1.9.1.20?
Attachment #519395 - Flags: approval1.9.1.20+
Verified for 1.9.2.18 in source.
Keywords: verified1.9.2
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.