Closed
Bug 632994
Opened 13 years ago
Closed 13 years ago
When previewing personas, tab bar moves into title bar and jitters
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: mmm, Assigned: mmm)
References
Details
(Keywords: regression, Whiteboard: [hardblocker] [has patch])
Attachments
(2 files, 1 obsolete file)
427.47 KB,
video/webm
|
Details | |
801 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
According to dolske and fryn, this is a regression. Have not tested platforms other than Mac to see if the problem shows up.
Assignee | ||
Comment 1•13 years ago
|
||
Similarly to bug 616010, the UI does not jitter if already wearing a persona.
Assignee | ||
Comment 2•13 years ago
|
||
Tested out on nightlies, works in 02-04 (847a825087f2) but fails in 02-05 (4574f9e56d49). The corresponding changeset: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=847a825087f2&tochange=4574f9e56d49
Assignee | ||
Comment 3•13 years ago
|
||
Luckily there are still tinderbox builds. Narrowed it down to the change: http://hg.mozilla.org/mozilla-central/rev/51f36c6a7d38 from bug 627328
Updated•13 years ago
|
Component: General → XUL
Product: Firefox → Core
QA Contact: general → xptoolkit.widgets
Summary: Tab bar moves into title bar and jitters when trying on a persona → When previewing personas, tab bar moves into title bar and jitters
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mars.martian+bugmail
Comment 4•13 years ago
|
||
Assignee | ||
Comment 5•13 years ago
|
||
From reading bug 627328, it seemed like a script runner was thought of but never used. Tested this out and it solves the problem on Mac, going to run try builds to check other platforms.
Attachment #511235 -
Flags: review?(bzbarsky)
Should be a hardblocker IMO, the effect is nasty.
Updated•13 years ago
|
Attachment #511198 -
Attachment is obsolete: true
Updated•13 years ago
|
Attachment #511226 -
Attachment description: Free recording of problem. → Mehdi's screen recording of the bug now in webm!
Updated•13 years ago
|
blocking2.0: ? → final+
Whiteboard: [hardblocker]
Comment 7•13 years ago
|
||
Comment on attachment 511235 [details] [diff] [review] Patch v1, switched to using a script runner. r=me
Attachment #511235 -
Flags: review?(bzbarsky) → review+
Updated•13 years ago
|
Whiteboard: [hardblocker] → [hardblocker] [has patch]
Flags: in-litmus?
Flags: in-litmus? → in-testsuite?
Assignee | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/83a0538956cc
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•