633066 - Remove nsICiter and make nsInternetCiter a static class

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

nsICiter is completely internal to one small part of editor/ and can be removed, and then nsInternetCiter can be made a static class because its only member variable is its refcnt.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Ehsan, Sebastian is a new contributor working on his second bug.  I told him you wouldn't mind if he took this one :-)

Comment 2

[(no longer active)]

(In reply to comment #1)
> Ehsan, Sebastian is a new contributor working on his second bug.  I told him
> you wouldn't mind if he took this one :-)

I'd be very glad if he does!  :-)

Comment 3

[Sebastian Kromp]

Attachment: removed nsICiter and made nsInternetCiter static

Comment 4

[(no longer active)]

Comment on attachment 523072 [details] [diff] [review]
removed nsICiter and made nsInternetCiter static

This patch looks great, thanks!

I will land it for you on mozilla-central.

Comment 5

[(no longer active)]

Sebastian, here is a tip for you in order to generate better patches for other people to check in: <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f>

You don't need to make any changes to this patch, but you can use those guidelines in the future!  Let me know if you need any help.  :-)

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/b7534c685c11

Comment 7

[Sebastian Kromp]

(In reply to comment #5)
> Sebastian, here is a tip for you in order to generate better patches for other
> people to check in:
> <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f>
> 
> You don't need to make any changes to this patch, but you can use those
> guidelines in the future!  Let me know if you need any help.  :-)

Thank you very much! I have changed everything according to these guidelines and will use it in future submissions =)