Remove nsICiter and make nsInternetCiter a static class

RESOLVED FIXED in mozilla5

Status

()

Core
Editor
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: khuey, Assigned: Sebastian Kromp)

Tracking

(Blocks: 1 bug)

unspecified
mozilla5
x86
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [post-2.0])

Attachments

(1 attachment)

nsICiter is completely internal to one small part of editor/ and can be removed, and then nsInternetCiter can be made a static class because its only member variable is its refcnt.
Assignee: nobody → ehsan
Whiteboard: [post-2.0]
Ehsan, Sebastian is a new contributor working on his second bug.  I told him you wouldn't mind if he took this one :-)
Assignee: ehsan → 46b
(In reply to comment #1)
> Ehsan, Sebastian is a new contributor working on his second bug.  I told him
> you wouldn't mind if he took this one :-)

I'd be very glad if he does!  :-)
(Assignee)

Comment 3

6 years ago
Created attachment 523072 [details] [diff] [review]
removed nsICiter and made nsInternetCiter static
Attachment #523072 - Flags: review?(ehsan)
Comment on attachment 523072 [details] [diff] [review]
removed nsICiter and made nsInternetCiter static

This patch looks great, thanks!

I will land it for you on mozilla-central.
Attachment #523072 - Flags: review?(ehsan) → review+
Sebastian, here is a tip for you in order to generate better patches for other people to check in: <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f>

You don't need to make any changes to this patch, but you can use those guidelines in the future!  Let me know if you need any help.  :-)
http://hg.mozilla.org/mozilla-central/rev/b7534c685c11
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
(Assignee)

Comment 7

6 years ago
(In reply to comment #5)
> Sebastian, here is a tip for you in order to generate better patches for other
> people to check in:
> <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f>
> 
> You don't need to make any changes to this patch, but you can use those
> guidelines in the future!  Let me know if you need any help.  :-)

Thank you very much! I have changed everything according to these guidelines and will use it in future submissions =)
You need to log in before you can comment on or make changes to this bug.