633164 - Zoomed ogg video renders at the wrong size until I move the mouse

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Mats Palmgren (inactive)]

Zoomed ogg video renders at the wrong size until I move the mouse.

STEPS TO REPRODUCE
1. load http://en.wikipedia.org/wiki/File:Big_Buck_Bunny_small.ogv
2. click the play button on the (top) video and move the mouse away from it
3. CTRL++ a few times
4. move the mouse
5. CTRL+0

ACTUAL RESULTS
After 3, the video is zoomed to much.  After moving the mouse it's
rendered at the right size (sometimes I need to mouse over the video
itself to fix it).  At 5, the video is too small; again, moving the
mouse fixes it.

PLATFORMS AND BUILDS TESTED
Bug occurs in Firefox nightly build:
Mozilla/5.0 (X11; Linux x86_64; rv:2.0b12pre) Gecko/20110210 Firefox/4.0b12pre

Comment 1

[Timothy Nikkel (:tnikkel)]

I'm going to guess that bug 615870 caused this.

Comment 2

[Mats Palmgren (inactive)]

Yes, bug 615870 is in the regression window:  2010-12-27-03 -- 2010-12-28-03
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=24b63f638579&tochange=e928817fb4e9

Comment 3

[Timothy Nikkel (:tnikkel)]

So an invalidate originating in the view system that doesn't come from the frame system is what we rely on to do the correct repainting here.

Comment 4

[Timothy Nikkel (:tnikkel)]

Or maybe an invalidate from the video code that needs to update the layer tree instead of just recomposite the layer tree.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, I think nsMediaDecoder::Invalidate under mSizeChanged should call frame->Invalidate().

Comment 6

[Timothy Nikkel (:tnikkel)]

Hmm, that doesn't actually fix it.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Well, it should anyway!

Comment 8

[Mats Palmgren (inactive)]

Attachment: wip

It doesn't work because mSizeChanged isn't affected by zooming.

This patch seems to fix the issue for me.

Comment 9

[Timothy Nikkel (:tnikkel)]

Comment on attachment 512708 [details] [diff] [review]
wip

Seems right, but I don't know video that well.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 512708 [details] [diff] [review]
wip

+    }
+    else {

} else {

Please add comments to mSizeChanged and mImageContainerSizeChanged detailing exactly what they mean.

Comment 11

[Mats Palmgren (inactive)]

Attachment: v2

Nits fixed.  Please take a quick look at the updated comments and
let me know if they make sense.

Comment 12

[Mats Palmgren (inactive)]

http://hg.mozilla.org/mozilla-central/rev/7a9b17cca93d

Comment 13

[u279076]

Cannot reproduce with Firefox 4.0b12pre 20110218 -- marking verified.